fix: Handle MAX_INT_256 #9511

mankenavenkatesh · 2021-06-14T05:02:20Z

Change maxBitLen of sdk.Int to handle max Erc20 value.

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

Change maxBitLen of sdk.Int to handle max Erc20 value.

zmanian · 2021-06-14T05:26:27Z

This is a dependency for Gravity.

SDK.Int was always intended to support up ERC20 max supply.

fedekunze

ACK, can you add a changelog entry?

codecov · 2021-06-14T11:12:37Z

Codecov Report

Merging #9511 (161c111) into master (38d6702) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 161c111 differs from pull request most recent head d50db36. Consider uploading reports for the commit d50db36 to get more accurate results

@@           Coverage Diff           @@
##           master    #9511   +/-   ##
=======================================
  Coverage   60.58%   60.59%           
=======================================
  Files         589      589           
  Lines       37218    37211    -7     
=======================================
- Hits        22548    22547    -1     
+ Misses      12726    12721    -5     
+ Partials     1944     1943    -1

Impacted Files	Coverage Δ
types/decimal.go	`70.12% <0.00%> (ø)`
types/int.go	`72.91% <ø> (ø)`
server/config/toml.go	`18.18% <0.00%> (ø)`
server/config/config.go	`41.81% <0.00%> (+0.37%)`	⬆️
server/grpc/grpc_web.go	`66.66% <0.00%> (+19.99%)`	⬆️

CHANGELOG.md

webmaster128 · 2021-06-14T15:37:40Z

types/int_test.go

@@ -69,7 +69,7 @@ func (s *intTestSuite) TestIntPanic() {
 	s.Require().Panics(func() { i2.Neg().Mul(i2.Neg()) })
 	s.Require().Panics(func() { i3.Neg().Mul(i3.Neg()) })

-	// Underflow check
+	// // Underflow check


By the way, this is not an underflow

Storing values that are too low in an integer variable (e.g., attempting to store −1 in an unsigned integer) is properly referred to as integer overflow, or more broadly, integer wraparound. The term underflow normally refers to floating point numbers only, which is a separate issue.

https://en.wikipedia.org/wiki/Arithmetic_underflow

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

aaronc

utACK

robert-zaremba

let's create a const for the common expression which is repeated multiple times.

robert-zaremba · 2021-06-14T23:05:42Z

types/decimal.go

@@ -319,7 +319,7 @@ func (d Dec) QuoRoundUp(d2 Dec) Dec {
 	quo := new(big.Int).Quo(mul, d2.i)
 	chopped := chopPrecisionAndRoundUp(quo)

-	if chopped.BitLen() > 255+DecimalPrecisionBits {
+	if chopped.BitLen() > (maxBitLen + DecimalPrecisionBits) {


Let's create a constant for maxBitLen + DecimalPrecisionBits. It's repeated few times.

robert-zaremba · 2021-06-14T23:06:20Z

types/int.go

@@ -9,7 +9,7 @@ import (
 	"math/big"
 )

-const maxBitLen = 255
+const maxBitLen = 256


why previously it was 255 instead of 256?

amaury1093 · 2021-06-16T09:36:47Z

Could you allow write access to your branch? So that the mergify bot can merge master and you don't have to constantly do it manually.

Change maxBitLen of sdk.Int to handle max Erc20 value.  ## Description Closes: #XXXX  --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)

Change maxBitLen of sdk.Int to handle max Erc20 value.  Closes: #XXXX  --- *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)

Handle MAX_INT_256

efe4177

Change maxBitLen of sdk.Int to handle max Erc20 value.

mankenavenkatesh changed the title ~~Handle MAX_INT_256~~ fix: Handle MAX_INT_256 Jun 14, 2021

albertchon mentioned this pull request Jun 14, 2021

Handle MAX_INT_256 and malicious ER20 sends PeggyJV/gravity-bridge#44

Closed

mankenavenkatesh marked this pull request as ready for review June 14, 2021 05:20

mankenavenkatesh requested review from aaronc and alexanderbez as code owners June 14, 2021 05:20

zmanian approved these changes Jun 14, 2021

View reviewed changes

fedekunze approved these changes Jun 14, 2021

View reviewed changes

mankenavenkatesh and others added 3 commits June 14, 2021 11:14

Update CHANGELOG.md

adf73ca

Use maxBitLen instead of hardcoded value in sdk.Dec overflow checks.

94b91e5

Merge branch 'master' into handle_MAX_INT_256

0a80ea9

fedekunze reviewed Jun 14, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

alexanderbez approved these changes Jun 14, 2021

View reviewed changes

webmaster128 reviewed Jun 14, 2021

View reviewed changes

albertchon and others added 2 commits June 14, 2021 12:47

Update CHANGELOG.md

3f284ea

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

Merge branch 'master' into handle_MAX_INT_256

202ee48

aaronc requested review from amaury1093 and robert-zaremba June 14, 2021 21:00

aaronc approved these changes Jun 14, 2021

View reviewed changes

robert-zaremba approved these changes Jun 14, 2021

View reviewed changes

albertchon and others added 2 commits June 15, 2021 10:50

Merge branch 'master' into handle_MAX_INT_256

c3492be

constant for maxDecBitLen

161c111

amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 16, 2021

Merge branch 'master' into handle_MAX_INT_256

d50db36

mergify bot merged commit 3841df6 into cosmos:master Jun 16, 2021

albertchon deleted the handle_MAX_INT_256 branch June 16, 2021 14:22

fedekunze mentioned this pull request Jun 29, 2021

use sdk.Int for TxData's chain-id and amount evmos/ethermint#207

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Handle MAX_INT_256 #9511

fix: Handle MAX_INT_256 #9511

mankenavenkatesh commented Jun 14, 2021 •

edited

Loading

zmanian commented Jun 14, 2021

fedekunze left a comment

codecov bot commented Jun 14, 2021 •

edited

Loading

webmaster128 Jun 14, 2021

aaronc left a comment

robert-zaremba left a comment

robert-zaremba Jun 14, 2021

albertchon Jun 16, 2021

robert-zaremba Jun 14, 2021

amaury1093 commented Jun 16, 2021

fix: Handle MAX_INT_256 #9511

fix: Handle MAX_INT_256 #9511

Conversation

mankenavenkatesh commented Jun 14, 2021 • edited Loading

Description

Author Checklist

Reviewers Checklist

zmanian commented Jun 14, 2021

fedekunze left a comment

Choose a reason for hiding this comment

codecov bot commented Jun 14, 2021 • edited Loading

Codecov Report

webmaster128 Jun 14, 2021

Choose a reason for hiding this comment

aaronc left a comment

Choose a reason for hiding this comment

robert-zaremba left a comment

Choose a reason for hiding this comment

robert-zaremba Jun 14, 2021

Choose a reason for hiding this comment

albertchon Jun 16, 2021

Choose a reason for hiding this comment

robert-zaremba Jun 14, 2021

Choose a reason for hiding this comment

amaury1093 commented Jun 16, 2021

mankenavenkatesh commented Jun 14, 2021 •

edited

Loading

codecov bot commented Jun 14, 2021 •

edited

Loading