-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle MAX_INT_256 and malicious ER20 sends #44
Comments
I think it already does work this way, as a natural outcome of ctx.CacheContext on https://github.com/PeggyJV/gravity-bridge/blob/main/module/x/gravity/keeper/ethereum_event_vote.go#L120 |
cosmos/cosmos-sdk#9511 closes this issue |
I don't see anything in ctx.CacheContext that will catch a panic. I think this only handles an error and not a panic. |
We need a panic handler here. Not just an error handler. |
should be in the test case.
We need a check in
func (a EthereumEventProcessor) Handle
to ensure that adding the amount send to Cosmos doesn't overflow the max size of SDK.Int.If it does overflow we should increment the event nonce but ignore the amount sent.
The text was updated successfully, but these errors were encountered: