Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.34.0 (master) #4036

Merged
merged 111 commits into from
Apr 15, 2019
Merged

Release v0.34.0 (master) #4036

merged 111 commits into from
Apr 15, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Apr 3, 2019

Release v0.34.0 into master. PR into develop: #4086.

TODO (prior to merge):

Nice-to-Have:


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

sunnya97 and others added 30 commits March 7, 2019 09:02
Release 0.33.0 to Develop
Merge v0.33.0 tag back to develop
* Make cli tests use build files

* Update PENDING.md

Add PR number.
Temporarily remove snap from installation instructions
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
`gaiacli keys add a123 --multisig a1,a2,a3 --multisig-threshold 2`
`gaiacli keys add temp --recover` with incorrect mnemonic
* Make IsAllGTE() more consistent

Co-Authored-By: alessio <quadrispro@ubuntu.com>
* Add indent to JSON of `gaiacli key list`

* Add `-o json --indent` to `keys [add|show|list]`

* Add change log.

* Move entry from CHANGELOG.md to PENDING.md

* Update PENDING.md

Add indent to JSON of `gaiacli key [add|show|list]`

Co-Authored-By: yangyanqing <yangyanqing.cn@gmail.com>
@@ -35,7 +36,7 @@ set_macos_env: &macos_env
docs_update: &docs_deploy
working_directory: ~/repo
docker:
- image: tendermint/docs_deployment
- image: tendermintdev/jq_curl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez changed the title Release/v0.34.0 (master) Release v0.34.0 (master) Apr 10, 2019
@alexanderbez alexanderbez mentioned this pull request Apr 10, 2019
5 tasks
@alessio
Copy link
Contributor

alessio commented Apr 15, 2019

Why is this still on hold?

@alexanderbez
Copy link
Contributor Author

Why is this still on hold?

Needs an approval and merge from @jaekwon

@jackzampolin jackzampolin merged commit 7cb3422 into master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.