Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify magic string "json" to OutputFormatJSON #3840

Merged
merged 1 commit into from
Mar 9, 2019
Merged

Modify magic string "json" to OutputFormatJSON #3840

merged 1 commit into from
Mar 9, 2019

Conversation

yangyanqing
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.(Just correct a magic string)

  • Wrote tests (Just correct a magic string)

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 9, 2019

Codecov Report

Merging #3840 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #3840      +/-   ##
===========================================
+ Coverage    60.92%   60.94%   +0.01%     
===========================================
  Files          192      192              
  Lines        14323    14323              
===========================================
+ Hits          8727     8729       +2     
+ Misses        5027     5025       -2     
  Partials       569      569

@jackzampolin
Copy link
Member

Thank you for fixing that! @yangyanqing!

@jackzampolin jackzampolin merged commit 4e38c79 into cosmos:develop Mar 9, 2019
@yangyanqing yangyanqing deleted the frank/modify-magic-string branch March 15, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants