R4R: Fix duplicate json key in SetWithdrawAddress

[hendrikhofstadt]

Closes #2940

• Targeted PR against correct branch (see CONTRIBUTING.md)

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

• Wrote tests

• Updated relevant documentation (docs/)

• Added entries in PENDING.md with issue #

• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[fedekunze]

I like this idea. We need to double check that the msg type matches the tag, otherwise we should label this as breaking changes.

Also please make sure to update https://github.com/cosmos/cosmos-sdk/blob/develop/docs/gaia/gaiacli.md#matching-a-set-of-tags

[hendrikhofstadt]

@fedekunze Yes they indeed don't match. I am currently fixing all tests and will update everything as you said 👍

[codecov]

Codecov Report

Merging #2944 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2944   +/-   ##
========================================
  Coverage    56.32%   56.32%           
========================================
  Files          120      120           
  Lines         8417     8417           
========================================
  Hits          4741     4741           
  Misses        3354     3354           
  Partials       322      322

[alexanderbez]

LGTM. I think the integration_tests is a regression due to the latest TM update? Not sure.

[hendrikhofstadt]

@alexanderbez Thanks for the review 👍 yes it is. I fixed the integration test in #2943 and we are tracking the root cause in #2945

[alexanderbez]

Thanks for the update and staying on top of it @SLAMPER!

[ValarDragon]

Awesome!

[jackzampolin]

This is now failing due to an out of date IAVL dep. Can you rebase on develop @SLAMPER?

[hendrikhofstadt]

@jackzampolin uhm. I just changed a single string. Sure that I have to rebase ?

[jackzampolin]

@SLAMPER The commit that tendermint/iavl was pinned to got squashed, so yes.

[hendrikhofstadt]

@jackzampolin Oh just saw it. Did a rebase 👍