Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Fix tag usage in handlers and EndBlocker #2943

Merged
merged 8 commits into from
Nov 29, 2018
Merged

R4R: Fix tag usage in handlers and EndBlocker #2943

merged 8 commits into from
Nov 29, 2018

Conversation

hendrikhofstadt
Copy link
Contributor

@hendrikhofstadt hendrikhofstadt commented Nov 29, 2018

Closes #2941

The tags of the staking EndBlocker have been ignored by now and action tags were added twice for some transactions.

CC @cwgoes - could we get this in for v0.27.0 since this is a blocker for our block explorer?

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@hendrikhofstadt hendrikhofstadt changed the title Fix tag usage in handlers and EndBlocker WIP: Fix tag usage in handlers and EndBlocker Nov 29, 2018
@codecov
Copy link

codecov bot commented Nov 29, 2018

Codecov Report

Merging #2943 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2943      +/-   ##
===========================================
- Coverage     56.3%   56.29%   -0.02%     
===========================================
  Files          120      120              
  Lines         8420     8411       -9     
===========================================
- Hits          4741     4735       -6     
+ Misses        3357     3354       -3     
  Partials       322      322

@hendrikhofstadt hendrikhofstadt changed the title WIP: Fix tag usage in handlers and EndBlocker R4R: Fix tag usage in handlers and EndBlocker Nov 29, 2018
@cwgoes cwgoes self-assigned this Nov 29, 2018
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK; please add a PENDING.md entry, and we should fix the ability of invalid public keys to halt the state machine (#2945), but that can be done separately.

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@hendrikhofstadt
Copy link
Contributor Author

@cwgoes Updated docs and pending 👍

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants