Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: misc fixes for cosmos-rosetta #13578

Closed
wants to merge 9 commits into from
Closed

fix: misc fixes for cosmos-rosetta #13578

wants to merge 9 commits into from

Conversation

raynaudoe
Copy link
Contributor

Description

Closes:
#13083
#11402
#10678
#12358
#10776
#12934

This PR introduces the first batch of fixes for rosetta.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

rllola and others added 8 commits September 28, 2022 11:09
@rllola
hardcode block identifier (#3)
ca4600d 
fix missing coma

should work

print block height answer

why index null

should fix getHeight

forgot fmt

fix get account at current height

check rosetta request

misc

misc

misc

misc

misc

misc

misc

misc

infinite loop
@raynaudoe @rllola
feat: Add go.mod for rosetta server (#4)
8e16c4d 
* Add go.mod for rosetta server

* Update go.mod files

* Fix go.mod
@raynaudoe
fix: minor fixes (#18)
8bc14eb 
* Print messages when rosetta is online and when it cannot connect to rpc server

* Fix masking underlaying error

* Delete fmt output

* Avoid getting genesis block at Ready(), use Health and Status calls instead
@rllola
throw an error in case of config conflict (rosetta offline mode) (#20)
fae4897
@rllola
Fix blockidentifier not specify (#33)
75b7dfc
@raynaudoe
Parse base64 encoded events (#38)
b392c12
@raynaudoe
Fix genesis block response (#42)
9426399 
* Get genesis hash from env

* Print error message if hash env is not set
@raynaudoe
Merge branch 'main' into main-Zondax
9a624d1
@tac0turtle
Copy link
Member

seems there was an issue with the rebase

@raynaudoe
Copy link
Contributor Author

seems there was an issue with the rebase

yep. fixed on this one #13583.
Closing ...

@raynaudoe raynaudoe closed this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt Awaiting requested review from julienrbrt julienrbrt will be requested when the pull request is marked ready for review julienrbrt is a code owner

@tac0turtle tac0turtle Awaiting requested review from tac0turtle tac0turtle will be requested when the pull request is marked ready for review tac0turtle is a code owner

@auricom auricom Awaiting requested review from auricom auricom will be requested when the pull request is marked ready for review auricom is a code owner

@facundomedica facundomedica Awaiting requested review from facundomedica facundomedica will be requested when the pull request is marked ready for review facundomedica is a code owner

@cool-develope cool-develope Awaiting requested review from cool-develope cool-develope will be requested when the pull request is marked ready for review cool-develope is a code owner

@akhilkumarpilli akhilkumarpilli Awaiting requested review from akhilkumarpilli akhilkumarpilli will be requested when the pull request is marked ready for review akhilkumarpilli is a code owner

@lucaslopezf lucaslopezf Awaiting requested review from lucaslopezf lucaslopezf will be requested when the pull request is marked ready for review lucaslopezf is a code owner

@testinginprod testinginprod Awaiting requested review from testinginprod testinginprod will be requested when the pull request is marked ready for review testinginprod is a code owner

@JulianToledano JulianToledano Awaiting requested review from JulianToledano JulianToledano will be requested when the pull request is marked ready for review JulianToledano is a code owner

@ziscky ziscky Awaiting requested review from ziscky ziscky will be requested when the pull request is marked ready for review ziscky is a code owner

@alpe alpe Awaiting requested review from alpe alpe will be requested when the pull request is marked ready for review alpe is a code owner

@kocubinski kocubinski Awaiting requested review from kocubinski kocubinski will be requested when the pull request is marked ready for review kocubinski is a code owner

@sontrinh16 sontrinh16 Awaiting requested review from sontrinh16 sontrinh16 will be requested when the pull request is marked ready for review sontrinh16 is a code owner

@hieuvubk hieuvubk Awaiting requested review from hieuvubk hieuvubk will be requested when the pull request is marked ready for review hieuvubk is a code owner

@aaronc aaronc Awaiting requested review from aaronc aaronc will be requested when the pull request is marked ready for review aaronc is a code owner

Assignees
No one assigned
Labels
C:CLI C:Cosmovisor Issues and PR related to Cosmovisor C:orm C:Rosetta Issues and PR related to Rosetta C:Simulations C:Store C:x/auth C:x/authz C:x/bank C:x/capability C:x/crisis C:x/distribution distribution module related C:x/evidence C:x/feegrant C:x/genutil genutil module issues C:x/gov C:x/group C:x/mint C:x/nft C:x/params C:x/slashing C:x/staking C:x/upgrade Type: ADR Type: Build Type: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raynaudoe @tac0turtle @rllola