Rosetta: spin rosetta out into its own go.mod #13083
Assignees
Labels
C:Rosetta
Issues and PR related to Rosetta
Comments
|
I think it would be best to move rosetta to its own repo and remove everything rosetta related from the sdk, that would help to update and fix things more dynamically. |
|
what's the issue with keeping it in the sdk? separate go.mod treats it the same as a separate repo but has a higher integration with the product. |
|
no issue at all, I think it would be ok to do a virtual split between rosetta and the sdk in the same repo using another go.mod file. Maybe some internal reorg would be necessary |
19 tasks
19 tasks
mergify bot
pushed a commit
that referenced
this issue
Nov 4, 2022
### Description Closes: #13083 #11402 #10678 #12358 #10776 #12934 ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Rosetta should have its own release process, right now its coupled with the sdk.
Proposal
Spin rosetta out into its own go.mod and tag a release. We should wait for approval from @jleni for when to cut v1
The text was updated successfully, but these errors were encountered: