Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove group go.mod #10971

Merged
merged 3 commits into from
Jan 19, 2022
Merged

chore: remove group go.mod #10971

merged 3 commits into from
Jan 19, 2022

Conversation

aleem1314
Copy link
Contributor

Description

Closes: #10970


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the T: CI label Jan 19, 2022
@aleem1314 aleem1314 marked this pull request as ready for review January 19, 2022 10:13
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also discussed removing x/nft's go.mod. Can we do it in the same PR? (and cc @marbar3778, ok to remove nft's go mod too for now?)

@blushi
Copy link
Contributor

blushi commented Jan 19, 2022

We also discussed removing x/nft's go.mod. Can we do it in the same PR? (and cc @marbar3778, ok to remove nft's go mod too for now?)

it seems like a different approach has been taken for x/nft, see #10970 (comment)

EDIT: it seems like x/nft doesn't actually have any go.mod for now (#10578)

Copy link
Contributor

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you resolve the conflicts? @aleem1314

@blushi blushi added the A:automerge Automatically merge PR once all prerequisites pass. label Jan 19, 2022
@mergify mergify bot merged commit ca4360a into master Jan 19, 2022
@mergify mergify bot deleted the aleem/10970-group-gomod branch January 19, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T: CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temporarily remove go.mod from x/group
3 participants