Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use x/nft as a standalone module #10578

Closed
wants to merge 6 commits into from

Conversation

dreamer-zq
Copy link
Collaborator

Description

Closes: #9826


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dreamer-zq dreamer-zq changed the title feat: Use x/nft as a standalone module feat: use x/nft as a standalone module Nov 19, 2021
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this be 1.0 from the first release? Also should it target 0.44?

@dreamer-zq
Copy link
Collaborator Author

There is a problem with this PR temporarily, because after nft becomes an independent project, the simapp in cosmos-sdk cannot be used directly, so the test code cannot pass now. Is there any good solution?

@tac0turtle
Copy link
Member

There is a problem with this PR temporarily, because after nft becomes an independent project, the simapp in cosmos-sdk cannot be used directly, so the test code cannot pass now. Is there any good solution?

you can recreate a minimal simp for simulations, this is until we have better a testing design .

Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. How about the sim tests?

@aaronc
Copy link
Member

aaronc commented Nov 24, 2021

I see two approvals but I don't see how this PR can work because it depends on simapp still and simulations with x/nft won't actually run.

@robert-zaremba
Copy link
Collaborator

I think the idea is what @marbar3778 suggested:

  1. Create a new simapp in x/nft/simapp package
  2. in operations_test create simapp from x/nft/simapp

In both cases we need need to double check the CI if the tests are running.

@dreamer-zq
Copy link
Collaborator Author

I think the idea is what @marbar3778 suggested:

  1. Create a new simapp in x/nft/simapp package
  2. in operations_test create simapp from x/nft/simapp

In both cases we need need to double check the CI if the tests are running.

👌🏻,i got it

@@ -0,0 +1,600 @@
package simapp

import (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this, any chance you can get rid of all modules except what is needed? this will help with reducing the changes needed in this file in the future.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should probably be closed because someone is doing the same thing

@tac0turtle
Copy link
Member

tac0turtle commented Jan 14, 2022

closing this for now based of comment above

@tac0turtle tac0turtle closed this Jan 14, 2022
@blushi blushi mentioned this pull request Jan 19, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement ADR-043-nft
4 participants