Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove account getters in CLIContext #4543

Closed
4 tasks
colin-axner opened this issue Jun 12, 2019 · 1 comment · Fixed by #4579
Closed
4 tasks

Remove account getters in CLIContext #4543

colin-axner opened this issue Jun 12, 2019 · 1 comment · Fixed by #4579
Assignees
@alessio
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@colin-axner
Copy link
Contributor

Summary

Remove account getters in client context.

Problem Definition

x/auth has the queriers necessary for retrieving account information. These functions should be removed since they are currently redundant and don't provide any extra value.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@rigelrozanski rigelrozanski mentioned this issue Jun 13, 2019
Closed
8 tasks
@alexanderbez alexanderbez added the S:blocked Status: Blocked label Jun 13, 2019
@alexanderbez
Copy link
Contributor

blocked on #4488

@alexanderbez alexanderbez removed the S:blocked Status: Blocked label Jun 15, 2019
@alexanderbez alexanderbez changed the title remove account getters in client context Remove account getters in CLIContext Jun 15, 2019
@alexanderbez alexanderbez added pre1.0 Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Jun 15, 2019
alessio added a commit that referenced this issue Jun 18, 2019
@alessio
Separate account getters from client/context
4fa7fcf 
Closes: #4543
@alessio alessio mentioned this issue Jun 18, 2019
Merged
5 tasks
alessio pushed a commit that referenced this issue Jun 19, 2019
Separate account getters from client/context (#4579)
1eb7706 
Account getters are removed from client context. x/auth has the
queriers necessary for retrieving account information.
These functions should be removed since they are currently
redundant and don't provide any extra value.

Closes: #4543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alessio alessio

Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Separate account getters from client/context cosmos/cosmos-sdk
3 participants
@alessio @alexanderbez @colin-axner