Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple auth module from other SDK top-level core packages #4488

Closed
2 of 8 tasks
alessio opened this issue Jun 5, 2019 · 5 comments
Closed
2 of 8 tasks

Decouple auth module from other SDK top-level core packages #4488

alessio opened this issue Jun 5, 2019 · 5 comments
Assignees
@alessio
Milestone
v1.0 LTS

Comments

@alessio
Copy link
Contributor

alessio commented Jun 5, 2019 •
edited by robert-zaremba
Loading

Technical task

We want to remove auth package dependency from the following core packages:

  • client
  • simapp (unsure about this)
  • server
  • client/tx/legacy.go

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez
Copy link
Contributor

Would be helpful to first list the dependencies 👍

@alessio alessio added this to the v1.0 LTS milestone Jun 5, 2019
@rigelrozanski rigelrozanski mentioned this issue Jun 5, 2019
Closed
8 tasks
alessio added a commit that referenced this issue Jun 6, 2019
@alessio
Remove unnecessary auth dependency from the server package
1b69845 
Ref #4488
This was referenced Jun 6, 2019
Merged
Merged
alessio added a commit that referenced this issue Jun 7, 2019
@alessio
Generalize auth/types.StdSignature into an SDK type
d11aca7 
New Signature interface available in the top level types package.
auth.StdSignature implements such interface. User defined auth
module can now define their own custom signature types.

Work carried out in the context of the following issues:
- #4488
- #4487
alessio pushed a commit that referenced this issue Jun 7, 2019
Generalize auth/types.StdSignature (#4507)
a32d5a4 
New Signature interface available in the top level types package.
auth.StdSignature implements such interface. User defined auth
module can now define their own custom signature types.

Work carried out in the context of the following issues:
- #4488
- #4487
alessio added a commit that referenced this issue Jun 7, 2019
@alessio
Generalize auth/type.StdFee
3b32456 
A new Fee interface is made available in the top level types package.
auth.StdFee implements such interface. User defined auth module can
now define their own custom fee types.

Work carried out in the context of the following issues:
- #4488
- #4487
@alessio alessio mentioned this issue Jun 7, 2019
Closed
5 tasks
@rigelrozanski
Copy link
Contributor

Evaluation:

required to be moved into auth/

  • utils
  • rest
  • tx

context/ decoders will no longer depend on auth after #4543 (so context is fine)

Fine staying in auth (everything else):
flags = good
input = good
lcd = good
keys = good
rpc = good
client/ (root) = good

@alexanderbez
Copy link
Contributor

Took a stab at #4543 and that will be much easier once this is done (because if util/). So I'm blocking #4543 on this.

@alexanderbez alexanderbez mentioned this issue Jun 13, 2019
Closed
4 tasks
alessio added a commit that referenced this issue Jun 14, 2019
@alessio
Move client/{tx,rest,utils} into x/auth/client
39fe7df 
Ref: #4488
@alessio alessio mentioned this issue Jun 14, 2019
Merged
5 tasks
@alessio alessio self-assigned this Jun 19, 2019
alessio added a commit that referenced this issue Jun 19, 2019
@alessio
Remove auth's AccountDecoder type.
6541b63 
AccountDecoder is now entirely redundant.
client package now does no longer depend on x/auth.

Context: #4488
@alessio alessio mentioned this issue Jun 19, 2019
Merged
5 tasks
alessio pushed a commit that referenced this issue Jun 19, 2019
Remove auth's AccountDecoder type (#4588)
c530c1c 
AccountDecoder is now entirely redundant.
client package now does no longer depend on x/auth.

Context: #4488
@alessio
Copy link
Contributor Author

alessio commented Jun 20, 2019

I had a conversation with @rigelrozanski about simapp, we think that it is an exception as it is in fact an app. As such, it's OK for simapp to depend on x/auth.

@alessio
Copy link
Contributor Author

alessio commented Jun 20, 2019

Work has been done, top level packages don't depend on x/auth anymore. Test evidence follows:

alessio@bangalter:~/work/cosmos-sdk$ go list -f '{{ .Deps }}' ./crypto/... | grep auth
alessio@bangalter:~/work/cosmos-sdk$ go list -f '{{ .Deps }}' ./baseapp/... | grep auth
alessio@bangalter:~/work/cosmos-sdk$ go list -f '{{ .Deps }}' ./server/... | grep auth
alessio@bangalter:~/work/cosmos-sdk$ go list -f '{{ .Deps }}' ./store/... | grep auth
alessio@bangalter:~/work/cosmos-sdk$ go list -f '{{ .Deps }}' ./tests/... | grep auth
alessio@bangalter:~/work/cosmos-sdk$ go list -f '{{ .Deps }}' ./types/... | grep auth
alessio@bangalter:~/work/cosmos-sdk$ go list -f '{{ .Deps }}' ./version/... | grep auth
alessio@bangalter:~/work/cosmos-sdk$ go list -f '{{ .Deps }}' ./client/... | grep auth
alessio@bangalter:~/work/cosmos-sdk$

Hence closing.

@alessio alessio closed this as completed Jun 20, 2019
@alessio alessio mentioned this issue Sep 15, 2020
Merged
9 tasks
@robert-zaremba robert-zaremba mentioned this issue Sep 15, 2020
Closed
9 tasks
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this issue May 22, 2023
Generalize auth/types.StdSignature (cosmos#4507)
eba8653 
New Signature interface available in the top level types package.
auth.StdSignature implements such interface. User defined auth
module can now define their own custom signature types.

Work carried out in the context of the following issues:
- cosmos#4488
- cosmos#4487
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alessio alessio

Labels
None yet
Projects
None yet
Milestone
v1.0 LTS
Development

No branches or pull requests
3 participants
@alessio @alexanderbez @rigelrozanski