Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(renderingEngine): fix the signature of resize method #630

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

rogerbramon
Copy link
Contributor

@rogerbramon rogerbramon commented May 24, 2023

Context

There's a mismatch between the signature of the resize method defined in the interface IRenderingEngine and RenderingEngine obtaining the complete opposite result.

IRenderingEngine:
resize(immediate?: boolean, resetPan?: boolean, resetZoom?: boolean): void;

RenderingEngine:
public resize(immediate = true, keepCamera = true): void {

Changes & Results

Fix the signature of resize method.

Testing

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: macOS 13
  • Node version: 18
  • Browser: Chrome 113

@netlify
Copy link

netlify bot commented May 24, 2023

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit fcc8258
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/646e40e7ee0183000870e316
😎 Deploy Preview https://deploy-preview-630--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sedghi sedghi merged commit 7b6f855 into cornerstonejs:main Jun 14, 2023
@rogerbramon rogerbramon deleted the fix-resize-signature branch June 14, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants