Skip to content

Commit

Permalink
fix(types): fix the signature of resize method (#630)
Browse files Browse the repository at this point in the history
* fix(renderingEngine): fix the signature of resize method

* Update API documentation
  • Loading branch information
rogerbramon authored Jun 14, 2023
1 parent 24ae3c9 commit 7b6f855
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion common/reviews/api/core.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -1532,7 +1532,7 @@ interface IRenderingEngine {
// (undocumented)
renderViewports(viewportIds: Array<string>): void;
// (undocumented)
resize(immediate?: boolean, resetPan?: boolean, resetZoom?: boolean): void;
resize(immediate?: boolean, keepCamera?: boolean): void;
// (undocumented)
setViewports(viewports: Array<PublicViewportInput>): void;
}
Expand Down
2 changes: 1 addition & 1 deletion common/reviews/api/streaming-image-volume-loader.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -1064,7 +1064,7 @@ interface IRenderingEngine {
// (undocumented)
renderViewports(viewportIds: Array<string>): void;
// (undocumented)
resize(immediate?: boolean, resetPan?: boolean, resetZoom?: boolean): void;
resize(immediate?: boolean, keepCamera?: boolean): void;
// (undocumented)
setViewports(viewports: Array<PublicViewportInput>): void;
}
Expand Down
2 changes: 1 addition & 1 deletion common/reviews/api/tools.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -2801,7 +2801,7 @@ interface IRenderingEngine {
// (undocumented)
renderViewports(viewportIds: Array<string>): void;
// (undocumented)
resize(immediate?: boolean, resetPan?: boolean, resetZoom?: boolean): void;
resize(immediate?: boolean, keepCamera?: boolean): void;
// (undocumented)
setViewports(viewports: Array<PublicViewportInput>): void;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/types/IRenderingEngine.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export default interface IRenderingEngine {
offscreenMultiRenderWindow: any;
offScreenCanvasContainer: any;
setViewports(viewports: Array<PublicViewportInput>): void;
resize(immediate?: boolean, resetPan?: boolean, resetZoom?: boolean): void;
resize(immediate?: boolean, keepCamera?: boolean): void;
getViewport(id: string): IStackViewport | IVolumeViewport;
getViewports(): Array<IStackViewport | IVolumeViewport>;
render(): void;
Expand Down

0 comments on commit 7b6f855

Please sign in to comment.