add model workflows #304
add model workflows #304
Conversation
Signed-off-by: sallyom <somalley@redhat.com>
sallyom
requested review from
MichaelClifford,
rhatdan,
lmilbaum and
cgwalters
as code owners
There was a problem hiding this comment.
@sallyom firstly this is awesome stuff. Also my appologies this should have been included with #300 so thanks for adding this! However I would like to move to a matrix based approach with all our workflows as it is easier and safer to extend. You dont have to take the following suggestions but I highly recommend:
| MERLINITE_MODEL_IMAGE_NAME: merlinite-7b-lab | ||
| MERLINITE_LABEL: Q4_K_M | ||
| MERLINITE_MODEL_URL: https://huggingface.co/instructlab/merlinite-7b-lab-GGUF/resolve/main/merlinite-7b-lab-Q4_K_M.gguf | ||
| MISTRAL_MODEL_IMAGE_NAME: mistral-7b-instruct | ||
| MISTRAL_LABEL: v0.1.Q4_K_M.gguf | ||
| MISTRAL_MODEL_URL: https://huggingface.co/TheBloke/Mistral-7B-Instruct-v0.1-GGUF/resolve/main/mistral-7b-instruct-v0.1.Q4_K_M.gguf | ||
| GRANITE_MODEL_IMAGE_NAME: granite-7b-lab | ||
| GRANITE_LABEL: Q4_K_M | ||
| GRANITE_MODEL_URL: https://huggingface.co/instructlab/granite-7b-lab-GGUF/resolve/main/granite-7b-lab-Q4_K_M.gguf |
There was a problem hiding this comment.
We should do these using our make targets for greater test coverage via a matrix rather than hardcoding values into the ENV, see example in ms workflows
| MERLINITE_MODEL_IMAGE_NAME: merlinite-7b-lab | |
| MERLINITE_LABEL: Q4_K_M | |
| MERLINITE_MODEL_URL: https://huggingface.co/instructlab/merlinite-7b-lab-GGUF/resolve/main/merlinite-7b-lab-Q4_K_M.gguf | |
| MISTRAL_MODEL_IMAGE_NAME: mistral-7b-instruct | |
| MISTRAL_LABEL: v0.1.Q4_K_M.gguf | |
| MISTRAL_MODEL_URL: https://huggingface.co/TheBloke/Mistral-7B-Instruct-v0.1-GGUF/resolve/main/mistral-7b-instruct-v0.1.Q4_K_M.gguf | |
| GRANITE_MODEL_IMAGE_NAME: granite-7b-lab | |
| GRANITE_LABEL: Q4_K_M | |
| GRANITE_MODEL_URL: https://huggingface.co/instructlab/granite-7b-lab-GGUF/resolve/main/granite-7b-lab-Q4_K_M.gguf |
There was a problem hiding this comment.
matrix approach works for me! it'll be much better
| id: build_granite_model_image | ||
| uses: redhat-actions/buildah-build@v2 | ||
| with: | ||
| image: ${{ env.GRANITE_MODEL_IMAGE_NAME }} |
There was a problem hiding this comment.
Based on my above suggestion this will move to a matrix based approach, ex ms model downloads via matrix
| platforms: linux/amd64, linux/arm64 | ||
| context: models | ||
| labels: | | ||
| ${{ env.GRANITE_LABEL }} |
There was a problem hiding this comment.
Another env --> matrix refactor
| labels: | | ||
| ${{ env.GRANITE_LABEL }} | ||
| build-args: | | ||
| MODEL_URL=${{ env.GRANITE_MODEL_URL }} |
There was a problem hiding this comment.
Another env --> matrix refactor
| image: ${{ env.MERLINITE_MODEL_IMAGE_NAME }} | ||
| tags: latest | ||
| platforms: linux/amd64, linux/arm64 | ||
| context: models | ||
| labels: | | ||
| ${{ env.MERLINITE_LABEL }} | ||
| build-args: | | ||
| MODEL_URL=${{ env.MERLINITE_MODEL_URL }} | ||
| containerfiles: ./models/Containerfile |
There was a problem hiding this comment.
Same as discussed above
|
One thing you should also do is include is more targeted It should look something like this: on:
schedule: # schedule the job to run at 12 AM daily
- cron: '0 0 * * *'
pull_request:
branches:
- main
paths:
- ./models/Makefile
- .github/workflows/model_image_build_push.yaml
push:
branches:
- main
paths:
- ./models/Makefile
- .github/workflows/model_image_build_push.yaml |
|
It was determined we want to push ahead and get these images in Quay ASAP. I will follow on with a refactor PR adressing the concerns laid out above. |
There was a problem hiding this comment.
/lgtm
@Gregory-Pereira to refactor after images get created
|
@Gregory-Pereira is going to refactor this and make it 1000% better, I'm merging this as/is to populate these images |
adding merlinite & granite model workflow