Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding merlinite and granite models #300

Merged
merged 1 commit into from
Apr 22, 2024
Merged

adding merlinite and granite models #300

merged 1 commit into from
Apr 22, 2024

Conversation

Gregory-Pereira
Copy link
Collaborator

@Gregory-Pereira Gregory-Pereira added ready-for-review models Anything related to models (upgrades, swap, etc) labels Apr 22, 2024
sallyom
sallyom reviewed Apr 22, 2024
View reviewed changes
models/Makefile Outdated
$(MAKE) MODEL_URL=https://huggingface.co/instructlab/granite-7b-lab-GGUF/resolve/main/granite-7b-lab-Q4_K_M.gguf MODEL_NAME=granite-7b-lab-Q4_K_M.gguf download-model

.PHONY: download-model-merlinite
download-model-granite:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

granite->merlinite on #L25

@Gregory-Pereira
adding merlinite and granite models
5ffe3e9 
Signed-off-by: greg pereira <grpereir@redhat.com>
sallyom
sallyom approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@sallyom sallyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rhatdan
Copy link
Member

rhatdan commented Apr 22, 2024

LGTM

@rhatdan rhatdan merged commit 462d26e into containers:main Apr 22, 2024
1 check passed
@Gregory-Pereira Gregory-Pereira mentioned this pull request Apr 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sallyom sallyom sallyom approved these changes

@MichaelClifford MichaelClifford Awaiting requested review from MichaelClifford MichaelClifford is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@lmilbaum lmilbaum Awaiting requested review from lmilbaum lmilbaum is a code owner

@cgwalters cgwalters Awaiting requested review from cgwalters cgwalters is a code owner

Assignees
No one assigned
Labels
models Anything related to models (upgrades, swap, etc) ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gregory-Pereira @rhatdan @sallyom