Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace pkg/errors #93

Merged
merged 1 commit into from
Sep 26, 2021
Merged

replace pkg/errors #93

merged 1 commit into from
Sep 26, 2021

Conversation

zouyee
Copy link
Contributor

@zouyee zouyee commented Sep 22, 2021

Signed-off-by: Zou Nengren zouyee1989@gmail.com

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2021

Codecov Report

Merging #93 (81faa3e) into main (360e86c) will increase coverage by 3.40%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   70.75%   74.15%   +3.40%     
==========================================
  Files          11       11              
  Lines         612      708      +96     
==========================================
+ Hits          433      525      +92     
- Misses        142      148       +6     
+ Partials       37       35       -2     
Impacted Files Coverage Δ
channel.go 88.23% <0.00%> (+6.41%) ⬆️
client.go 84.53% <0.00%> (+3.00%) ⬆️
codec.go 66.66% <0.00%> (+6.66%) ⬆️
config.go 33.33% <ø> (+3.33%) ⬆️
server.go 76.19% <ø> (+1.70%) ⬆️
services.go 47.36% <0.00%> (+5.57%) ⬆️
unixcreds_linux.go 53.84% <0.00%> (+3.84%) ⬆️
handshake.go 100.00% <0.00%> (ø)
interceptor.go 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 360e86c...81faa3e. Read the comment docs.

client.go Outdated Show resolved Hide resolved
server_test.go Outdated Show resolved Hide resolved
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
@zouyee zouyee marked this pull request as ready for review September 25, 2021 14:47
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 77fc8a4 into containerd:main Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants