Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pkg/errors from vendor #6049

Closed
zouyee opened this issue Sep 25, 2021 · 4 comments
Closed

remove pkg/errors from vendor #6049

zouyee opened this issue Sep 25, 2021 · 4 comments

Comments

@zouyee
Copy link
Contributor

zouyee commented Sep 25, 2021

What is the problem you're trying to solve

Remove all uses of pkg/errors, switching to native Go error (un)wrapping.
xref: opencontainers/runc#3011

Describe the solution you'd like

Vendor PR PR status cut
containerd/aufs containerd/aufs#33 Merged
containerd/btrfs containerd/btrfs#35 Merged
containerd/cgroups containerd/cgroups#208
containerd/console containerd/console#54 Merged v1.0.3
containerd/continuity containerd/continuity#185 Merged v0.2.0
containerd/fifo containerd/fifo#41 Merged
containerd/go-cni containerd/go-cni#71 Merged v1.1.0
containerd/go-runc containerd/go-runc#80 Merged
containerd/imgcrypt containerd/imgcrypt#54 Merged
containerd/nri containerd/nri#17 Merged
containerd/ttrpc containerd/ttrpc#93
containerd/typeurl containerd/typeurl#29 Merged
containerd/zfs containerd/zfs#52 Merged
containerd/containerd

Additional context

No response

@zouyee
Copy link
Contributor Author

zouyee commented Sep 25, 2021

/cc @estesp @AkihiroSuda

@mcbenjemaa
Copy link

find . -name "*.go" |  grep -v vendor/ | { xargs grep 'github.com/pkg/errors' -sl || true; }

./filters/quote.go
./filters/parser.go
./cmd/ctr/commands/tasks/checkpoint.go
./cmd/ctr/commands/tasks/start.go
./cmd/ctr/commands/tasks/tasks_windows.go
./cmd/ctr/commands/tasks/ps.go
./cmd/ctr/commands/tasks/kill.go
./cmd/ctr/commands/tasks/tasks_unix.go
./cmd/ctr/commands/pprof/pprof.go
./cmd/ctr/commands/snapshots/snapshots.go
./cmd/ctr/commands/images/unmount.go
./cmd/ctr/commands/images/pull.go
./cmd/ctr/commands/images/export.go
./cmd/ctr/commands/images/convert.go
./cmd/ctr/commands/images/images.go
./cmd/ctr/commands/images/push.go
./cmd/ctr/commands/images/mount.go
./cmd/ctr/commands/content/content.go
./cmd/ctr/commands/oci/oci.go
./cmd/ctr/commands/namespaces/namespaces.go
./cmd/ctr/commands/leases/leases.go
./cmd/ctr/commands/resolver.go
./cmd/ctr/commands/containers/checkpoint.go
./cmd/ctr/commands/containers/containers.go
./cmd/ctr/commands/containers/restore.go
./cmd/ctr/commands/run/run.go
./cmd/ctr/commands/run/run_unix.go
./cmd/ctr/commands/run/run_windows.go
./cmd/ctr/commands/shim/shim.go
./cmd/containerd/command/service_windows.go
./cmd/containerd/command/publish.go
./cmd/containerd/command/main.go
./cmd/containerd-shim/main_unix.go
./tracing/plugin/otlp.go
./task_opts_unix.go
./pull.go
./platforms/platforms.go
./platforms/cpuinfo.go
./rootfs/apply.go
./rootfs/init.go
./task.go
./archive/tar_windows.go
./archive/tar_linux_test.go
./archive/tar.go
./archive/time_unix.go
./archive/tar_test.go
./archive/tar_unix.go
./snapshots/btrfs/btrfs.go
./snapshots/btrfs/btrfs_test.go
./snapshots/native/native.go
./snapshots/testsuite/helpers.go
./snapshots/benchsuite/benchmark_test.go
./snapshots/lcow/lcow.go
./snapshots/storage/metastore_test.go
./snapshots/storage/bolt.go
./snapshots/storage/metastore.go
./snapshots/devmapper/pool_device.go
./snapshots/devmapper/config.go
./snapshots/devmapper/metadata.go
./snapshots/devmapper/plugin/plugin.go
./snapshots/devmapper/dmsetup/dmsetup.go
./snapshots/devmapper/snapshotter.go
./snapshots/devmapper/metadata_test.go
./snapshots/windows/windows.go
./snapshots/overlay/overlay.go
./snapshots/overlay/overlayutils/check.go
./images/mediatypes.go
./images/archive/importer.go
./images/archive/exporter.go
./images/archive/reference.go
./images/handlers.go
./images/image.go
./integration/container_stats_test.go
./integration/imagefs_info_test.go
./integration/containerd_image_test.go
./integration/client/content_test.go
./integration/client/container_linux_test.go
./integration/client/daemon_test.go
./integration/main_test.go
./task_opts.go
./container_checkpoint_opts.go
./runtime/v1/linux/task.go
./runtime/v1/linux/bundle.go
./runtime/v1/linux/runtime.go
./runtime/v1/linux/process.go
./runtime/v1/shim/service_unix.go
./runtime/v1/shim/service.go
./runtime/v1/shim/service_linux.go
./runtime/v1/shim/client/client_linux.go
./runtime/v1/shim/client/client.go
./runtime/restart/monitor/monitor.go
./runtime/restart/monitor/change.go
./runtime/v2/binary.go
./runtime/v2/bundle.go
./runtime/v2/shim_unix.go
./runtime/v2/runc/v1/service.go
./runtime/v2/runc/v2/service.go
./runtime/v2/runc/platform.go
./runtime/v2/runc/container.go
./runtime/v2/process.go
./runtime/v2/manager.go
./runtime/v2/shim_windows_test.go
./runtime/v2/shim.go
./runtime/v2/shim/util_unix.go
./runtime/v2/shim/shim_unix.go
./runtime/v2/shim/util.go
./runtime/v2/shim/util_windows.go
./runtime/v2/shim/shim.go
./runtime/v2/shim/shim_windows.go
./runtime/v2/shim_windows.go
./runtime/v2/logging/logging_windows.go
./runtime/task_list.go
./plugin/plugin.go
./plugin/context.go
./labels/validate.go
./errdefs/grpc_test.go
./errdefs/grpc.go
./errdefs/errors.go
./client.go
./content/proxy/content_writer.go
./content/testsuite/testsuite.go
./content/local/store.go
./content/local/readerat.go
./content/local/locks.go
./content/local/writer.go
./content/helpers.go
./oci/spec_opts.go
./oci/utils_unix.go
./oci/spec_opts_windows.go
./diff/apply/apply.go
./diff/apply/apply_linux.go
./diff/stream.go
./diff/lcow/lcow.go
./diff/walking/differ.go
./diff/stream_windows.go
./diff/windows/windows.go
./diff/stream_unix.go
./identifiers/validate.go
./contrib/apparmor/template.go
./contrib/apparmor/apparmor.go
./contrib/apparmor/apparmor_unsupported.go
./process.go
./namespaces/context.go
./container_restore_opts.go
./sys/filesys_windows.go
./sys/reaper/reaper_unix.go
./sys/socket_unix.go
./remotes/docker/authorizer.go
./remotes/docker/pusher.go
./remotes/docker/config/hosts.go
./remotes/docker/auth/fetch.go
./remotes/docker/converter.go
./remotes/docker/resolver_test.go
./remotes/docker/schema1/converter.go
./remotes/docker/registry.go
./remotes/docker/resolver.go
./remotes/docker/fetcher_test.go
./remotes/docker/httpreadseeker.go
./remotes/docker/fetcher.go
./remotes/docker/status.go
./remotes/handlers.go
./mount/mount_unix.go
./mount/fmountat_linux_test.go
./mount/lookup_unix.go
./mount/mount_linux.go
./mount/mount_freebsd.go
./mount/temp.go
./mount/losetup_linux.go
./mount/fmountat_linux.go
./mount/mount_windows.go
./container.go
./gc/scheduler/scheduler.go
./unpacker.go
./image.go
./events/exchange/exchange.go
./events/exchange/exchange_test.go
./cio/io_windows.go
./cio/io_unix.go
./container_opts.go
./metadata/gc.go
./metadata/content_test.go
./metadata/db.go
./metadata/containers_test.go
./metadata/leases.go
./metadata/leases_test.go
./metadata/images_test.go
./metadata/db_test.go
./metadata/buckets_test.go
./metadata/boltutil/helpers.go
./metadata/bolt.go
./metadata/containers.go
./metadata/snapshot_test.go
./metadata/images.go
./metadata/content.go
./metadata/snapshot.go
./metadata/namespaces.go
./services/tasks/service.go
./services/tasks/local_unix.go
./services/tasks/local.go
./services/snapshots/service.go
./services/images/service.go
./services/content/service.go
./services/content/contentserver/contentserver.go
./services/diff/service.go
./services/diff/local.go
./services/server/server.go
./services/server/config/config.go
./services/introspection/service.go
./services/namespaces/service.go
./services/leases/service.go
./services/opt/service.go
./services/containers/service.go
./services/events/service.go
./pkg/ttrpcutil/client.go
./pkg/netns/netns_linux.go
./pkg/netns/netns_other.go
./pkg/registrar/registrar.go
./pkg/oom/v1/v1.go
./pkg/oom/v2/v2.go
./pkg/dialer/dialer.go
./pkg/cap/cap_linux.go
./pkg/cri/util/deep_copy.go
./pkg/cri/config/config.go
./pkg/cri/io/helpers_windows.go
./pkg/cri/cri.go
./pkg/cri/server/container_stats.go
./pkg/cri/server/container_update_resources_other.go
./pkg/cri/server/sandbox_stop.go
./pkg/cri/server/container_exec.go
./pkg/cri/server/container_stats_list_windows.go
./pkg/cri/server/sandbox_run.go
./pkg/cri/server/container_create.go
./pkg/cri/server/container_stats_list_other.go
./pkg/cri/server/container_stop.go
./pkg/cri/server/sandbox_run_linux.go
./pkg/cri/server/sandbox_remove.go
./pkg/cri/server/service.go
./pkg/cri/server/update_runtime_config.go
./pkg/cri/server/update_runtime_config_test.go
./pkg/cri/server/snapshots.go
./pkg/cri/server/sandbox_portforward_other.go
./pkg/cri/server/service_windows.go
./pkg/cri/server/container_attach.go
./pkg/cri/server/sandbox_run_windows.go
./pkg/cri/server/sandbox_portforward.go
./pkg/cri/server/container_create_linux.go
./pkg/cri/server/image_remove.go
./pkg/cri/server/service_linux.go
./pkg/cri/server/events.go
./pkg/cri/server/container_stats_list.go
./pkg/cri/server/container_remove.go
./pkg/cri/server/helpers_linux.go
./pkg/cri/server/cni_conf_syncer.go
./pkg/cri/server/sandbox_status.go
./pkg/cri/server/sandbox_portforward_linux.go
./pkg/cri/server/container_execsync.go
./pkg/cri/server/restart.go
./pkg/cri/server/container_stats_list_linux.go
./pkg/cri/server/container_update_resources_linux.go
./pkg/cri/server/container_log_reopen.go
./pkg/cri/server/container_status.go
./pkg/cri/server/container_start.go
./pkg/cri/server/helpers.go
./pkg/cri/server/sandbox_portforward_windows.go
./pkg/cri/server/streaming.go
./pkg/cri/server/container_create_linux_test.go
./pkg/cri/server/image_pull.go
./pkg/cri/server/image_status.go
./pkg/cri/opts/spec_linux.go
./pkg/cri/opts/spec_windows.go
./pkg/cri/opts/spec.go
./pkg/cri/opts/container.go
./pkg/cri/store/image/fake_image.go
./pkg/cri/store/image/image.go
./pkg/cri/store/container/metadata.go
./pkg/cri/store/container/status.go
./pkg/cri/store/sandbox/metadata.go
./pkg/process/exec_state.go
./pkg/process/deleted_state.go
./pkg/process/io.go
./pkg/process/exec.go
./pkg/process/utils.go
./pkg/process/init_state.go
./pkg/process/init.go
./install.go

@kzys
Copy link
Member

kzys commented Jan 31, 2022

Resolving.

Sorry, we still technically have pkg/errors under vendor/ due to gotest.tools/v3.

https://github.com/containerd/containerd/search?q=pkg%2Ferrors

That being said, I'm inclined to close this issue since we wouldn't do much regarding that.

@kzys kzys closed this as completed Jan 31, 2022
@kzys kzys reopened this Jan 31, 2022
@kzys
Copy link
Member

kzys commented Feb 18, 2022

Resolving. It is up to gotest.tools/v3. No actions from our end.

@kzys kzys closed this as completed Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants