Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace pkg/errors and bump related library #54

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

zouyee
Copy link

@zouyee zouyee commented Sep 22, 2021

replace pkg/errors and bump related(console、container and go-cni etc.) library

Signed-off-by: Zou Nengren zouyee1989@gmail.com

@zouyee
Copy link
Author

zouyee commented Sep 22, 2021

/cc @estesp @AkihiroSuda

@zouyee zouyee force-pushed the replaceerror branch 3 times, most recently from c07e57c to 02b3bff Compare September 22, 2021 08:07
@stefanberger
Copy link
Contributor

Are other projects replacing this package as well these days?

@zouyee
Copy link
Author

zouyee commented Sep 22, 2021

Are other projects replacing this package as well these days?

Yes

Copy link
Collaborator

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thanks so much for the PR @zouyee ! 1 very minor nit

cmd/ctr/commands/images/pull.go Outdated Show resolved Hide resolved
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
@stefanberger
Copy link
Contributor

LGTM. Thanks.

Copy link
Collaborator

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lumjjb lumjjb merged commit 967ee1f into containerd:master Sep 22, 2021
@zouyee zouyee deleted the replaceerror branch September 23, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants