Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test CI on the uninstaller fixes #696

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Test CI on the uninstaller fixes #696

merged 3 commits into from
Jul 13, 2023

Commits on Jul 13, 2023

  1. Merge pull request from GHSA-v8h5-w775-5rrw 

    * Only run uninstaller on directory with _conda.exe

* Do not run uninstaller in system-critical directories

* Add loop to check for minimum conda files

* Add missing goto after passing all checks

* Add push/pop operations to un.onInit

* Fix typo

* Use WordFind instead of UnStrTok

* Start WordFind loop with 1

* Add additional files to check for conda

* Add confirmation dialog before uninstalling

* Resolve INSTDIR

* Add exceptions to fill_template

* Do not replace NSIS predefines

* Add example template

* Update constructor/nsis/main.nsi.tmpl

Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>

* Add check for GetFullPathName

* Add additional directory checks for uninstaller

* Add quotes to INSTDIR in uninstaller message

* Add check to GetFullPathName

* Add additional directory checks for uninstaller

* Add check to GetFullPathName for uninstaller

* Remove duplicate comment

* Replace missing global variable with local variable

* Fix INSTDIR path resolution command

* Fix GetFullPathName logic

* Replace @name@ with ${NAME}

---------

Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
    @marcoesters @jaimergp
    marcoesters and jaimergp committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    e2739fb View commit details
    Browse the repository at this point in the history

  2. add news

    @jaimergp
    jaimergp committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    23ed336 View commit details
    Browse the repository at this point in the history

  3. Remove Scripts\activate.bat from required files on $INSTDIR (some ins… 

    …tallers do not ship conda)
    @jaimergp
    jaimergp committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    be315f2 View commit details
    Browse the repository at this point in the history