Test CI on the uninstaller fixes #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Only run uninstaller on directory with _conda.exe * Do not run uninstaller in system-critical directories * Add loop to check for minimum conda files * Add missing goto after passing all checks * Add push/pop operations to un.onInit * Fix typo * Use WordFind instead of UnStrTok * Start WordFind loop with 1 * Add additional files to check for conda * Add confirmation dialog before uninstalling * Resolve INSTDIR * Add exceptions to fill_template * Do not replace NSIS predefines * Add example template * Update constructor/nsis/main.nsi.tmpl Co-authored-by: jaimergp <jaimergp@users.noreply.github.com> * Add check for GetFullPathName * Add additional directory checks for uninstaller * Add quotes to INSTDIR in uninstaller message * Add check to GetFullPathName * Add additional directory checks for uninstaller * Add check to GetFullPathName for uninstaller * Remove duplicate comment * Replace missing global variable with local variable * Fix INSTDIR path resolution command * Fix GetFullPathName logic * Replace @name@ with ${NAME} --------- Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
conda-bot
added
the
cla-signed
…tallers do not ship conda)
jezdez
approved these changes
Jul 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This branch, contributed by @marcoesters, will prevent Windows uninstallers from deleting directories that do not correspond to the original installation.
Originally reported at ContinuumIO/anaconda-issues#11726
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?