Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging builds (from special builds) #21

Merged
merged 8 commits into from
Jan 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .azure-pipelines/azure-pipelines-linux.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 9 additions & 2 deletions .azure-pipelines/azure-pipelines-win.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 18 additions & 0 deletions .ci_support/linux_64_nsis_variantlog_enabled.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
cdt_name:
- cos6
channel_sources:
- conda-forge
channel_targets:
- conda-forge main
cxx_compiler:
- gxx
cxx_compiler_version:
- '11'
docker_image:
- quay.io/condaforge/linux-anvil-cos7-x86_64
nsis_variant:
- log_enabled
target_platform:
- linux-64
zlib:
- '1.2'
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,11 @@ channel_targets:
cxx_compiler:
- gxx
cxx_compiler_version:
- '10'
- '11'
docker_image:
- quay.io/condaforge/linux-anvil-cos7-x86_64
nsis_variant:
- standard
target_platform:
- linux-64
zlib:
Expand Down
8 changes: 8 additions & 0 deletions .ci_support/win_64_nsis_variantlog_enabled.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
channel_sources:
- conda-forge
channel_targets:
- conda-forge main
nsis_variant:
- log_enabled
target_platform:
- win-64
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,7 @@ channel_sources:
- conda-forge
channel_targets:
- conda-forge main
nsis_variant:
- standard
target_platform:
- win-64
2 changes: 1 addition & 1 deletion .github/CODEOWNERS

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 19 additions & 4 deletions README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 8 additions & 1 deletion recipe/bld.bat
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@ set "PREFIX_NSIS=%PREFIX%\NSIS"
cd binary
robocopy . "%PREFIX_NSIS%" /V /S /XD Docs Examples
if errorlevel 8 exit 1
cd ..

if exist binary_with_logging (
cd binary_with_logging
robocopy . "%PREFIX_NSIS%" /V /S /XD Docs Examples
if errorlevel 8 exit 1
cd ..
)

:: Copy the [de]activate scripts to %PREFIX%\etc\conda\[de]activate.d.
:: This will allow them to be run on environment activation.
Expand All @@ -10,7 +18,6 @@ FOR %%F IN (activate deactivate) DO (
COPY %RECIPE_DIR%\%%F.bat %PREFIX%\etc\conda\%%F.d\%PKG_NAME%_%%F.bat||exit 1
)

cd ..
cd plugins
copy "elevate\bin.x86-32\elevate.exe" "%PREFIX_NSIS%\Plugins\x86-unicode\"
if errorlevel 1 exit 1
Expand Down
30 changes: 19 additions & 11 deletions recipe/build.sh
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
export PREFIX_NSIS=$PREFIX/NSIS
export PREFIX_NSIS="$PREFIX/NSIS"

pushd binary
cp -r . "$PREFIX_NSIS"
rm -rf $PREFIX_NSIS/Docs
rm -rf $PREFIX_NSIS/Examples
rm -rf "$PREFIX_NSIS/Docs"
rm -rf "$PREFIX_NSIS/Examples"
popd

pushd plugins
Expand All @@ -14,20 +14,28 @@ cp "UnicodePathTest/Plugin/UnicodePathTest.dll" "$PREFIX_NSIS/Plugins/x86-unicod
cp "access-control/Plugins/i386-unicode/AccessControl.dll" "$PREFIX_NSIS/Plugins/x86-unicode/"
popd

extra_scons_options=""
extra_scons_targets=""
if [[ $nsis_variant == "log_enabled" ]]; then
extra_scons_options="NSIS_CONFIG_LOG=yes"
extra_scons_targets="install-stubs"
fi

cd src
scons \
VERSION="${PKG_VERSION}" \
CC="${CC}" CXX="${CXX}" APPEND_CCFLAGS="${CXXFLAGS}" APPEND_LINKFLAGS="${LDFLAGS}" \
SKIPSTUBS=all SKIPPLUGINS=all SKIPUTILS=all SKIPMISC=all \
NSIS_CONFIG_CONST_DATA_PATH=yes PREFIX=$PREFIX_NSIS \
-Q PATH=$PATH install-compiler
NSIS_CONFIG_CONST_DATA_PATH=yes PREFIX="$PREFIX_NSIS" \
-Q PATH="$PATH" $extra_scons_options \
install-compiler $extra_scons_targets

mkdir -p $PREFIX/bin
ln -sf $PREFIX_NSIS/bin/makensis $PREFIX_NSIS/makensis.exe
ln -sf $PREFIX_NSIS/bin/makensis $PREFIX/bin/makensis
mkdir -p "$PREFIX/bin"
ln -sf "$PREFIX_NSIS/bin/makensis" "$PREFIX_NSIS/makensis.exe"
ln -sf "$PREFIX_NSIS/bin/makensis" "$PREFIX/bin/makensis"

pushd $PREFIX_NSIS
mkdir share
pushd "$PREFIX_NSIS"
mkdir -p share
cd share
ln -sf $PREFIX_NSIS nsis
ln -sf "$PREFIX_NSIS" nsis
popd
3 changes: 3 additions & 0 deletions recipe/conda_build_config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
nsis_variant:
- log_enabled
- standard
11 changes: 10 additions & 1 deletion recipe/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ source:
- url: http://sourceforge.net/projects/nsis/files/NSIS%20{{ version.split(".")[0] }}/{{ version }}/nsis-{{ version }}.zip
sha256: 1bb9fc85ee5b220d3869325dbb9d191dfe6537070f641c30fbb275c97051fd0c
folder: binary

- url: http://sourceforge.net/projects/nsis/files/NSIS%20{{ version.split(".")[0] }}/{{ version }}/nsis-{{ version }}-log.zip # [win and nsis_variant == 'log_enabled']
sha1: 4fcb221a4dc4719580f201f6399b2035073aeaaa # [win and nsis_variant == 'log_enabled']
folder: binary_with_logging # [win and nsis_variant == 'log_enabled']

- url: http://sourceforge.net/projects/nsis/files/NSIS%20{{ version.split(".")[0] }}/{{ version }}/nsis-{{ version }}-src.tar.bz2 # [unix]
sha256: a85270ad5386182abecb2470e3d7e9bec9fe4efd95210b13551cb386830d1e87 # [unix]
folder: src # [unix]
Expand Down Expand Up @@ -36,8 +41,11 @@ source:
folder: plugins/access-control

build:
number: 0
number: 1
skip: True # [aarch64 or ppc64le or osx]
string: h{{ PKG_HASH }}_log_{{ PKG_BUILDNUM }} # [nsis_variant == 'log_enabled']
track_features:
- nsis_log_enabled # [nsis_variant == 'log_enabled']

requirements:
build:
Expand Down Expand Up @@ -71,3 +79,4 @@ extra:
- mbargull
- msarahan
- patricksnape
- jaimergp