Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging builds (from special builds) #21

Merged
merged 8 commits into from
Jan 26, 2023

Conversation

jaimergp
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Logging builds are useful for debugging. See https://nsis.sourceforge.io/Special_Builds. I am also adding myself as a maintainer.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@dbast
Copy link
Member

dbast commented Jan 20, 2023

Logging builds are e.g. used in the constructor tests for debugging.

The manual download from sourceforge there is not really reliable. Having it as conda package would improve that situation.

@conda-forge/nsis ready for review. thanks

@jaimergp
Copy link
Member Author

A week has passed with no answer. I am merging!

@jaimergp
Copy link
Member Author

@conda-forge-admin, please rerender

@github-actions
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/nsis-feedstock/actions/runs/4014391339.

@jaimergp jaimergp merged commit 1758a5a into conda-forge:main Jan 26, 2023
@jakirkham
Copy link
Member

@jaimergp, there were issues identified by @isuruf in the last PR that are not addressed. Think those should be handled before merging new things. Have raised an issue to track this ( #23 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants