-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forbid Pydantic >= 2 for napari 0.4.17 #50
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.07.03.16.57.58
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/napari-feedstock/actions/runs/5450077817. |
This kind of task is usually better solved by a repodata patch. Having it on the feedstock too doesn't hurt so the next release inherits it, but we definitely need the repo patch. Can you open one and we'll merge it quickly? Some examples: |
@@ -60,7 +60,7 @@ outputs: | |||
- pint >=0.17 | |||
- psutil >=5.0 | |||
- psygnal>=0.3.4 | |||
- pydantic >=1.9.0 | |||
- pydantic >=1.9.0,<2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have been <2.0a0
😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow really??? 🤦
Went ahead and posted conda-forge/conda-forge-repodata-patches-feedstock#477 |
Checklist
Reset the build number to0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)See napari/napari#6031 napari/napari#6029