Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid Pydantic >= 2 for napari 0.4.17 #50

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

jni
Copy link
Contributor

@jni jni commented Jul 4, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

See napari/napari#6031 napari/napari#6029

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jni
Copy link
Contributor Author

jni commented Jul 4, 2023

@conda-forge-admin, please rerender

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/napari-feedstock/actions/runs/5450077817.

@jni jni merged commit be866b1 into conda-forge:main Jul 4, 2023
3 checks passed
@jni jni deleted the forbid-pydantic-2 branch July 4, 2023 06:15
@jaimergp
Copy link
Member

jaimergp commented Jul 4, 2023

This kind of task is usually better solved by a repodata patch. Having it on the feedstock too doesn't hurt so the next release inherits it, but we definitely need the repo patch. Can you open one and we'll merge it quickly?

Some examples:

@@ -60,7 +60,7 @@ outputs:
- pint >=0.17
- psutil >=5.0
- psygnal>=0.3.4
- pydantic >=1.9.0
- pydantic >=1.9.0,<2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have been <2.0a0 😬

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow really??? 🤦

@jaimergp
Copy link
Member

jaimergp commented Jul 4, 2023

Went ahead and posted conda-forge/conda-forge-repodata-patches-feedstock#477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants