Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conda_build.config.subdir deprecation #318

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented May 14, 2024

Fixes #317

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

xref: #305

@jakirkham jakirkham requested a review from a team as a code owner May 14, 2024 00:13
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member Author

@conda-forge-admin , please re-render

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like I wasn't able to push to the fix_conda_build_subdir_dep branch of jakirkham-feedstocks/conda-forge-ci-setup-feedstock. Did you check the "Allow edits from maintainers" box?

NOTE: Our webservices cannot push to PRs from organization accounts or PRs from forks made from organization forks because of GitHub permissions. Please fork the feedstock directly from conda-forge into your personal GitHub account.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-ci-setup-feedstock/actions/runs/9071658113.

@jakirkham
Copy link
Member Author

Tried re-rendering locally. It seems to be changing a bunch of stuff (like dropping CUDA 11.2)

Going to hold off on that so we can focus on getting uploads working. Want to make sure even recently deprecated builds still get the fix

Can revisit after

@beckermr beckermr added the automerge Merge the PR when CI passes label May 14, 2024
@github-actions github-actions bot merged commit f98eca0 into conda-forge:main May 14, 2024
72 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@jakirkham jakirkham deleted the fix_conda_build_subdir_dep branch May 14, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validate_recipe_outputs failing due to missing conda_build.config.subdir (conda-build 24.5.0?)
2 participants