Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark broken conda/conda-build version 24.5.0 #995

Conversation

jakirkham
Copy link
Member

Some issues cropped up recently with conda-build version 24.5.0 and our package validation tooling ( conda-forge/conda-forge-ci-setup-feedstock#317 )

This marks conda & conda-build version 24.5.0 broken while we work out those issues. We can add them back after the issues have been addressed


Guidelines for marking packages as broken:

  • We prefer to patch the repo data (see here)
    instead of marking packages as broken. This alternative workflow makes environments more reproducible.
  • Packages with requirements/metadata that are too strict but otherwise work are
    not technically broken and should not be marked as such.
  • Packages with missing metadata can be marked as broken on a temporary basis
    but should be patched in the repo data and be marked unbroken later.
  • In some cases where the number of users of a package is small or it is used by
    the maintainers only, we can allow packages to be marked broken more liberally.
  • We (conda-forge/core) try to make a decision on these requests within 24 hours.

What will happen when a package is marked broken?

  • Our bots will add the broken label to the package. The main label will remain on the package and this is normal.
  • Our bots will rebuild our repodata patches to remove this package from the repodata.
  • In a few hours after the anaconda.org CDN picks up the new patches, you will no longer be able to install the package from the main channel.

Checklist:

  • I want to mark a package as broken (or not broken):

    • Added a description of the problem with the package in the PR description.
    • Pinged the team for the package for their input.
  • I want to archive a feedstock:

    • Pinged the team for that feedstock for their input.
    • Make sure you have opened an issue on the feedstock explaining why it was archived.
    • Linked that issue in this PR description.
    • Added links to any other relevant issues/PRs in the PR description.
  • I want to request (or revoke) access to an opt-in CI resource:

    • Pinged the relevant feedstock team(s)
    • Added a small description explaining why access is needed

@isuruf
Copy link
Member

isuruf commented May 14, 2024

Let's add a repodata patch to constrain the conda-build version in conda-forge-ci-setup.

@jakirkham
Copy link
Member Author

Our primary plan is to try fixing the problem: conda-forge/conda-forge-ci-setup-feedstock#318

This is our backup plan

That said, if someone wants to put together an alternative backup plan, great!

Personally need to step away from the computer for a bit

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is overkill. We could simply adjust the scripts locally in ci setup to force an older conda build if needed. There's no reason to mark it broken for everything.

@jakirkham
Copy link
Member Author

Closing as we fixed in conda-forge-ci-setup

@jakirkham jakirkham closed this May 14, 2024
@jakirkham jakirkham deleted the mark_conda_and_conda_build_24.5.0_broken branch May 14, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants