Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support manifest services without name #3085

Merged

Conversation

georgethebeatle
Copy link
Member

Co-authored-by: Danail Branekov danailster@gmail.com

Is there a related GitHub Issue?

#3050

What is this change about?

Both manifest service formats are now supported:

services:
  - my_service
  - name: your_service

Does this PR introduce a breaking change?

No

Acceptance Steps

See story

Tag your pair, your PM, and/or team

@danail-branekov

Both manifest service formats are now supported:

```
services:
  - my_service
  - name: your_service
```

Co-authored-by: Danail Branekov <danailster@gmail.com>
@danail-branekov danail-branekov enabled auto-merge (rebase) January 29, 2024 13:52
@georgethebeatle georgethebeatle linked an issue Jan 29, 2024 that may be closed by this pull request
@danail-branekov danail-branekov merged commit e3a0674 into main Jan 29, 2024
11 checks passed
@danail-branekov danail-branekov deleted the issues/3050-suppport-service-binding-without-name branch January 29, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support service bindings without name tag in manifests
2 participants