Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support service bindings without name tag in manifests #3050

Closed
danail-branekov opened this issue Jan 2, 2024 · 1 comment · Fixed by #3085
Closed

Support service bindings without name tag in manifests #3050

danail-branekov opened this issue Jan 2, 2024 · 1 comment · Fixed by #3085
Labels
mta support the MTA controller

Comments

@danail-branekov
Copy link
Member

No description provided.

@danail-branekov danail-branekov changed the title Support alternative service bindings in manifests Support service bindings without name tag in manifests Jan 2, 2024
@danail-branekov
Copy link
Member Author

Although this is not described in latest CF API v3 manifest schema, the name tag of a service could be omitted. it seems that there are plenty of already existing apps that leverage that format, so maybe we should support it.

Acceptance

GIVEN I have created a service instance my-service
WHEN I push the following manifest

---
version: 1
applications:
- name: my-app
services:
- my-service

THEN I see pushing the manifest succeeding and the app has been bound to the my-service service

@danail-branekov danail-branekov added the mta support the MTA controller label Jan 2, 2024
@georgethebeatle georgethebeatle linked a pull request Jan 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mta support the MTA controller
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant