-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(unstable_dev): Don't fetch from npm on boot #4347
Feat(unstable_dev): Don't fetch from npm on boot #4347
Conversation
🦋 Changeset detectedLatest commit: 9efd3ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6773272848/npm-package-wrangler-4347 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6773272848/npm-package-wrangler-4347 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6773272848/npm-package-wrangler-4347 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6773272848/npm-package-miniflare-4347 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6773272848/npm-package-cloudflare-pages-shared-4347 Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
Codecov Report
@@ Coverage Diff @@
## main #4347 +/- ##
==========================================
+ Coverage 75.35% 75.36% +0.01%
==========================================
Files 223 223
Lines 12341 12344 +3
Branches 3190 3193 +3
==========================================
+ Hits 9299 9303 +4
+ Misses 3042 3041 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably add as an option to pages dev in the future but not at all critical.
logLevel: options?.logLevel ?? defaultLogLevel, | ||
port: options?.port ?? 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remake of #2982
Fixes #2956.
What this PR solves / how to test:
Wrangler makes a HTTP request to the NPM registry, checking for updates to inform end users. While this makes sense in regular commands, it (generally) has little place in it's API, particularly when this is primarily used for tests.
This pull request adds an experimental option which disables the update check, and optionally allows users to enable it. (There are cases for this, such as
pages dev
)Author has addressed the following:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.