Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Feature Request: Don't run an update check in unstable_dev #2956

Closed
Skye-31 opened this issue Mar 28, 2023 · 2 comments · Fixed by #4347
Closed

🎉 Feature Request: Don't run an update check in unstable_dev #2956

Skye-31 opened this issue Mar 28, 2023 · 2 comments · Fixed by #4347
Labels
enhancement New feature or request wrangler Relating to the Wrangler CLI tool

Comments

@Skye-31
Copy link
Contributor

Skye-31 commented Mar 28, 2023

Which Cloudflare product(s) does this pertain to?

Wrangler

What version of Wrangler are you using?

2.13.0 (but happens in all prior versions too)

What operating system are you using?

Windows (though this doesn't have any effect)

Describe the Bug

When running a wrangler command, it'll make a request to https://registry.npmjs.org/wrangler to let you know if there's an update that you can install.

This behaviour also occurs in unstable_dev, which should not be the case, particularly when being used for things such as testing, as this slows the test down every time wrangler is run

@Skye-31 Skye-31 added the bug Something that isn't working label Mar 28, 2023
@penalosa penalosa changed the title 🐛 BUG: unstable_dev making requests to the NPM registry 🎉 Feature Request: Don't run an update check in unstable_dev May 22, 2023
@RamIdeas RamIdeas added enhancement New feature or request wrangler Relating to the Wrangler CLI tool and removed bug Something that isn't working bucket:cucumber labels Jun 26, 2023
@RamIdeas
Copy link
Contributor

This sounds reasonable. There's no need to slow down each dev run. It's also quite likely the warning will be seen when running other commands

@Skye-31
Copy link
Contributor Author

Skye-31 commented Jun 26, 2023

I have a PR open to resolve this, however it's been unanswered for a while 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wrangler Relating to the Wrangler CLI tool
Projects
Archived in project
3 participants