feat: FeeDecorator #323
Closed
feat: FeeDecorator #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we need more testing for the whole cometbft - sdk - core stack to make sure that oracleTx is prioritized. When I look at priority mempool feature, it belongs to mempool v1 in cometbft, not v0. Original oracleTx logic was implemented in v0 mempool and we are still using v0. To enable v1 mempool, it needs a configuration change here. 
In config.toml: 
Let's leave this item after this upgrade |
nghuyenthevinh2000
requested changes
Aug 20, 2023
|
I would rather recommend to remove support for mempool v0 and use mempool v1 as a default. Not optional. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Introducing new
FeeDecoratorfor AnteHandler that combines TaxFeeDecorator, DeductFeeDecorator, and BurnTaxFeeDecorator into one.This PR also includes oracle prioritization using mempool v1, which will eliminate the need of custom CometBFT. (classic-terra/cosmos-sdk#9)