Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Import Fork of Osmosis #252

Merged
merged 12 commits into from
Jun 27, 2023
Merged

feat(app): Import Fork of Osmosis #252

merged 12 commits into from
Jun 27, 2023

Conversation

alchemist-ti
Copy link
Contributor

@alchemist-ti alchemist-ti commented Jun 8, 2023

Summary of changes

Closes: #245

feat(app/upgrades): now supports upgrade and fork
feat: burn tax for testnets (It was disabled before BurnTaxUpgradeHeight regardless of ChainID)
refactor: extract constant variables and hard coded logics to types/fork

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@alchemist-ti alchemist-ti changed the title add fork logic Fork upgrade Jun 8, 2023
@alchemist-ti alchemist-ti marked this pull request as draft June 8, 2023 10:41
@inon-man inon-man added the enhancement New feature or request label Jun 21, 2023
@inon-man
Copy link
Collaborator

I think you missed README.md

osmosis-labs/osmosis@b71507c#diff-a1645678c0dc66a8c51a78dff88d73814fccc7e4c8706916784e64764eb7dc8b

@inon-man inon-man changed the title Fork upgrade Cherry pick Osmosis's Fork feature Jun 21, 2023
@inon-man inon-man changed the title Cherry pick Osmosis's Fork feature Cherry-pick Osmosis's Fork feature Jun 21, 2023
@inon-man inon-man changed the title Cherry-pick Osmosis's Fork feature feat(app): cherry-pick Osmosis's Fork feature Jun 21, 2023
@inon-man inon-man changed the title feat(app): cherry-pick Osmosis's Fork feature feat(app): cherry-pick Osmosis's fork feature Jun 21, 2023
@alchemist-ti
Copy link
Contributor Author

I think you missed README.md

osmosis-labs/osmosis@b71507c#diff-a1645678c0dc66a8c51a78dff88d73814fccc7e4c8706916784e64764eb7dc8b

Yeah, I will add it.

@alchemist-ti alchemist-ti marked this pull request as ready for review June 22, 2023 11:19
@inon-man

This comment was marked as resolved.

app/upgrades/v1/forks.go Outdated Show resolved Hide resolved
@inon-man inon-man self-requested a review June 23, 2023 00:10
@inon-man inon-man self-assigned this Jun 23, 2023
@inon-man
Copy link
Collaborator

@alchemist-ti I tried to dig history and refactored code and documents as much as possible. Please review whether this content is understood well.

@inon-man inon-man removed the request for review from edk208 June 23, 2023 00:17
@alchemist-ti
Copy link
Contributor Author

@alchemist-ti I tried to dig history and refactored code and documents as much as possible. Please review whether this content is understood well.

@inon-man awesome work! All looks good to me.

@inon-man inon-man changed the title feat(app): cherry-pick Osmosis's fork feature feat(app): Import Fork feature of Osmosis Jun 25, 2023
@inon-man inon-man changed the title feat(app): Import Fork feature of Osmosis feat(app): Import Fork of Osmosis Jun 25, 2023
@inon-man inon-man self-requested a review June 27, 2023 02:26
@inon-man inon-man merged commit 9d73c0d into main Jun 27, 2023
15 checks passed
@inon-man inon-man deleted the fork-upgrade branch June 27, 2023 10:23
@inon-man inon-man mentioned this pull request Jul 3, 2023
3 tasks
@inon-man inon-man added the backport/v2.1.x PR scheduled for inclusion in the v2.1's next stable release label Jul 23, 2023
mergify bot pushed a commit that referenced this pull request Jul 23, 2023
Co-authored-by: Inon Man <121477599+inon-man@users.noreply.github.com>
(cherry picked from commit 9d73c0d)
inon-man pushed a commit that referenced this pull request Jul 23, 2023
Co-authored-by: Inon Man <121477599+inon-man@users.noreply.github.com>
(cherry picked from commit 9d73c0d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v2.1.x PR scheduled for inclusion in the v2.1's next stable release enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Enhancement for upgrades and forks
3 participants