Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AmazonBedrockEmbeddingFunction support for Cohere Embed models #1675

Closed
wants to merge 5 commits into from

Conversation

JGalego
Copy link

@JGalego JGalego commented Jan 24, 2024

Description of changes

  • New functionality
    • Adds support for Cohere Embed models to AmazonBedrockEmbeddingFunction

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python

Also, manually tested with python:

>>> import boto3
>>> from chromadb.utils.embedding_functions import AmazonBedrockEmbeddingFunction
>>> session = boto3.Session()
>>> bedrock = AmazonBedrockEmbeddingFunction(session=session, model_name="cohere.embed-multilingual-v3")
>>> bedrock(["Hello World", "Olá Mundo"])
...

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@JGalego
Copy link
Author

JGalego commented Jan 30, 2024

@beggers reaching out to you b/c you were the last one to review+approve+merge changes to utils/embedding_functions.py (#1517). Can we find a reviewer for this one?

@atroyn atroyn self-requested a review February 15, 2024 23:23
@atroyn
Copy link
Contributor

atroyn commented Feb 15, 2024

Please also update the embedding model documentation: https://github.com/chroma-core/docs/blob/main/docs/embeddings.md

Currently the AmazonBedrockEmbeddingFunction is missing from the docs entirely.

@JGalego
Copy link
Author

JGalego commented Feb 16, 2024

Please also update the embedding model documentation: https://github.com/chroma-core/docs/blob/main/docs/embeddings.md

Currently the AmazonBedrockEmbeddingFunction is missing from the docs entirely.

There's an open PR from another contributor for the docs - chroma-core/docs#204

@chezou
Copy link
Contributor

chezou commented Feb 21, 2024

I've been waiting for the review for JS implementation as well #1659

Copy link
Contributor

@tazarov tazarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits.

chromadb/utils/embedding_functions.py Outdated Show resolved Hide resolved
chromadb/utils/embedding_functions.py Show resolved Hide resolved
chromadb/utils/embedding_functions.py Outdated Show resolved Hide resolved
chromadb/utils/embedding_functions.py Outdated Show resolved Hide resolved
@JGalego JGalego requested a review from tazarov April 22, 2024 21:01
@JGalego
Copy link
Author

JGalego commented May 3, 2024

@tazarov any other changes?

@jeffchuber
Copy link
Contributor

Our underlying impl has changed and so this PR is not landable as is.

That being said - we'd still like to add this functionality and that is now tracked in this issue.

@jeffchuber jeffchuber closed this Sep 15, 2024
@jeffchuber jeffchuber mentioned this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants