[BUG]Type errors in embading function #1169 #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b.com/DevMadhav13/chroma into type_errors_in_embading_function_1169
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
beggers
reviewed
Dec 14, 2023
| model_name: str = "all-MiniLM-L6-v2", | ||
| device: str = "cpu", | ||
| normalize_embeddings: bool = False, | ||
| self, |
There was a problem hiding this comment.
Please unindent these -- we don't want them double-indented.
| api_version: Optional[str] = None, | ||
| deployment_id: Optional[str] = None, | ||
| default_headers: Optional[Mapping[str, str]] = None, | ||
| self, |
There was a problem hiding this comment.
Please unindent these as well
| @@ -220,7 +222,7 @@ class HuggingFaceEmbeddingFunction(EmbeddingFunction[Documents]): | |||
| """ | |||
|
|
|||
| def __init__( | |||
| self, api_key: str, model_name: str = "sentence-transformers/all-MiniLM-L6-v2" | |||
| self, api_key: str, model_name: str = "sentence-transformers/all-MiniLM-L6-v2" | |||
There was a problem hiding this comment.
And here and everywhere below. I'll stop leaving comments about this :^)
|
@beggers Double-indents are removed now. |
beggers
reviewed
Dec 19, 2023
|
|
||
| # Return just the embeddings | ||
| return [result["embedding"] for result in sorted_embeddings] | ||
| embading = [result["embedding"] for result in sorted_embeddings] |
There was a problem hiding this comment.
nit: embedding, not embading
| @@ -36,7 +36,7 @@ class SentenceTransformerEmbeddingFunction(EmbeddingFunction[Documents]): | |||
| models: Dict[str, Any] = {} | |||
|
|
|||
| # If you have a beefier machine, try "gtr-t5-large". | |||
| # for a full list of options: https://huggingface.co/sentence-transformers, https://www.sbert.net/docs/pretrained_models.html | |||
| # for a full list of options: https://huggingface.co/sentence-transformers, https://www.sbert.net/docs/pretrained_models.html | |||
There was a problem hiding this comment.
nit: we added an extra space here, can we remove?
|
@beggers no Problem , corrections are done in new commit "Spell correction" |
rancomp
reviewed
Dec 21, 2023
beggers
reviewed
Dec 21, 2023
|
hey @DevMadhav13 if we can get my suggested minor changes into this PR then I'll merge it! Thank you for taking this work on -- makes our codebase more readable and easier to work in. |
Co-authored-by: Ran <rccalman@gmail.com>
Co-authored-by: Ben Eggers <64657842+beggers@users.noreply.github.com>
Co-authored-by: Ben Eggers <64657842+beggers@users.noreply.github.com>
|
@beggers Added suggested Commits which is missed to check. |
beggers
approved these changes
Jan 11, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Test plan
How are these changes tested?
pytestfor python,yarn testfor jsDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?