Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ubiquiti shadowserver parser #1383

Merged
14 commits merged into from
Mar 21, 2019
Merged

Ubiquiti shadowserver parser #1383

14 commits merged into from
Mar 21, 2019

Conversation

tomas321
Copy link
Contributor

@tomas321 tomas321 commented Mar 5, 2019

No description provided.

Sebastian Wagner and others added 14 commits December 7, 2018 14:45
@Teebor-Choka
PKG: Fix path patch for packages
388b5bd 
did contain the undefined name ROOT_DIR by error
@Teebor-Choka
PKG: debian/changelog: set 1.2.0~alpha1 as released
a7fa085
@Teebor-Choka
REL: Start development of 1.2.0~alpha2
1c760de
@Teebor-Choka
Merge pull request #7 from certtools/develop
3f51dbf 
Update repo
@tomas321
Merge pull request #8 from certtools/develop
65b5912 
Update from certtools
@tomas321
Merge pull request #9 from certtools/develop
b53846d 
Update repo
@tomas321
Merge pull request #10 from certtools/develop
071904e 
Update repo
@tomas321
Merge pull request #11 from certtools/develop
41f156e 
Update repo
@tomas321
Merge pull request #12 from certtools/develop
8a02b4c 
Sync to official repository
@tomas321
Merge pull request #13 from certtools/develop
5f580c7 
Sync to official repository
@tomas321
Merge pull request #14 from certtools/develop
1b4f184 
Sync with official repository
@tomas321
TST: Accessible Ubiquiti Discovery Service unit test
71e2339
@tomas321
Add feed parser for shadowserver Accessible Ubiquiti Discovery Service
acbaf63
@tomas321
Refactor Ubiquiti parser
4a0cc52
@codecov-io
Copy link

codecov-io commented Mar 5, 2019 •
edited
Loading

Codecov Report

Merging #1383 into develop will increase coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1383      +/-   ##
===========================================
+ Coverage    74.67%   74.71%   +0.03%     
===========================================
  Files          305      306       +1     
  Lines        13879    13899      +20     
  Branches      1868     1869       +1     
===========================================
+ Hits         10364    10384      +20     
  Misses        3098     3098              
  Partials       417      417
Impacted Files Coverage Δ
intelmq/bots/parsers/shadowserver/config.py 89.16% <100%> (+0.09%) ⬆️
...s/parsers/shadowserver/test_accessible_ubiquiti.py 100% <100%> (ø)

ghost
ghost approved these changes Mar 19, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me. Any further comments @th-certbund ?

@ghost ghost self-assigned this Mar 19, 2019
@ghost ghost added this to the 1.1.2 milestone Mar 19, 2019
@ghost ghost added feature Indicates new feature requests or new features component: bots labels Mar 19, 2019
@th-certbund
Copy link
Contributor

Looks good for me. Any further comments @th-certbund ?
No, I'm fine with it.

@ghost ghost merged commit 4a0cc52 into certtools:develop Mar 21, 2019
@ghost
Copy link

ghost commented Mar 21, 2019 •
edited by ghost
Loading

Thanks Tomas. Merged into maintenance and develop

Follow-up commit: 43f8fc7

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
component: bots feature Indicates new feature requests or new features
Projects
None yet
Milestone
1.1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@tomas321 @codecov-io @th-certbund @Teebor-Choka