Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mail url collector fix #1367

Closed
wants to merge 12 commits into from

Conversation

tomas321
Copy link
Contributor

@tomas321 tomas321 commented Jan 7, 2019

The Shadowserver mail body was changed to bytes object, which could not be parsed.

@ghost
Copy link

ghost commented Jan 8, 2019

Did you want to only submit 406f7aa4de4d1ca12cfe3372710224cc9eb85346?

@ghost ghost self-assigned this Jan 8, 2019
@tomas321
Copy link
Contributor Author

tomas321 commented Jan 8, 2019

Yes, only the change in process function

@codecov-io
Copy link

codecov-io commented Jan 9, 2019

Codecov Report

Merging #1367 into develop will increase coverage by 0.14%.
The diff coverage is 95.31%.

@@             Coverage Diff             @@
##           develop    #1367      +/-   ##
===========================================
+ Coverage    74.48%   74.63%   +0.14%     
===========================================
  Files          301      302       +1     
  Lines        13631    13656      +25     
  Branches      1844     1841       -3     
===========================================
+ Hits         10153    10192      +39     
+ Misses        3070     3057      -13     
+ Partials       408      407       -1
Impacted Files Coverage Δ
...ts/bots/parsers/shadowserver/test_http-scanners.py 100% <100%> (ø)
intelmq/bots/parsers/shadowserver/config.py 89.07% <100%> (+0.28%) ⬆️
...sts/bots/parsers/shadowserver/test_ics-scanners.py 100% <100%> (ø)
...ts/parsers/shadowserver/test_amplification-ddos.py 100% <100%> (ø)
intelmq/bots/collectors/mail/collector_mail_url.py 20.23% <25%> (+0.59%) ⬆️
intelmq/bots/outputs/restapi/output.py 60% <0%> (-4.71%) ⬇️
intelmq/tests/bots/parsers/twitter/test_parser.py 100% <0%> (ø) ⬆️
intelmq/bots/collectors/mail/lib.py
...ntelmq/bots/collectors/mail/collector_mail_body.py
... and 6 more

@ghost ghost added bug Indicates an unexpected problem or unintended behavior component: bots labels Feb 5, 2019
@ghost ghost added this to the 1.1.2 milestone Feb 5, 2019
@ghost ghost closed this in 80c6e3f Feb 5, 2019
@ghost
Copy link

ghost commented Feb 5, 2019

I also adapted the patch to the maintenance branch

I cherry-picked the one commit for develop.

Thanks for the patch

@ghost ghost reopened this Feb 5, 2019
@ghost ghost closed this Feb 5, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: bots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants