-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mail url collector fix #1367
Closed
Closed
Mail url collector fix #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
did contain the undefined name ROOT_DIR by error
Update repo
Did you want to only submit 406f7aa4de4d1ca12cfe3372710224cc9eb85346? |
ghost
self-assigned this
Jan 8, 2019
Yes, only the change in process function |
Update from certtools
tomas321
force-pushed
the
mail_url_collector_fix
branch
from
January 9, 2019 12:19
406f7aa
to
7683b5f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1367 +/- ##
===========================================
+ Coverage 74.48% 74.63% +0.14%
===========================================
Files 301 302 +1
Lines 13631 13656 +25
Branches 1844 1841 -3
===========================================
+ Hits 10153 10192 +39
+ Misses 3070 3057 -13
+ Partials 408 407 -1
|
Update repo
tomas321
force-pushed
the
mail_url_collector_fix
branch
from
January 10, 2019 11:46
7683b5f
to
272f1ab
Compare
ghost
added
bug
Indicates an unexpected problem or unintended behavior
component: bots
labels
Feb 5, 2019
ghost
added this to the 1.1.2 milestone
Feb 5, 2019
ghost
closed this
in
Feb 5, 2019
80c6e3f
I also adapted the patch to the maintenance branch I cherry-picked the one commit for develop. Thanks for the patch |
ghost
reopened this
Feb 5, 2019
ghost
closed this
Feb 5, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Shadowserver mail body was changed to bytes object, which could not be parsed.