allowing platform specification through flag #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
a-harhar
commented
Jan 24, 2024
a-harhar
commented
- allows platform specification through new flag --platform
- if not platform defaults to local (empty string)
- we should use --platform linux/amd64 for csci350 (not sure which one for csci104)
There was a problem hiding this comment.
Looks great! Thanks for adding this so quickly. Just had a small nit on the csci350 command.
not sure which one for csci104
It shouldn't be required for csci104 because the image is built for linux/amd64 and linux/arm64 already: https://github.com/csci104/docker/blob/main/.github/workflows/publish-image.yml#L34-L35
Co-authored-by: Cam <17013462+camerondurham@users.noreply.github.com>
|
Thanks for looking it over! Committed your suggestion :) -- really enjoyed working on this though, it's a great tool you made! The cs350-docker repo's README also needs to be updated |
camerondurham
approved these changes
Jan 24, 2024
|
Great, thanks! Yeah good callout. I'll need to update the README there once I minor version bump this to v0.3.7 so this gets built into the latest release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.