Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to specify image platform when creating ch shell #48

Closed
camerondurham opened this issue Jan 23, 2024 · 2 comments · Fixed by #49
Closed

Able to specify image platform when creating ch shell #48

camerondurham opened this issue Jan 23, 2024 · 2 comments · Fixed by #49
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@camerondurham
Copy link
Owner

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

ch should offer specifying the image platform you want to run with a platform flag.

This issue covers the feature required to create a shell env and specify the platform, but the cs350-docker repo needs to have documentation updated too.

@camerondurham camerondurham added bug Something isn't working enhancement New feature or request labels Jan 23, 2024
@camerondurham camerondurham self-assigned this Jan 23, 2024
@a-harhar
Copy link
Contributor

a-harhar commented Jan 23, 2024

@camerondurham I've been working on this locally, fairly certain I figured out how to do it. I'll make the PR for it shortly!

@a-harhar
Copy link
Contributor

@camerondurham created PR for adding the flag #49. Please leave any suggestions that you have on coding style and I can make the updates! Also not entirely sure if I updated all the places for documentation (I updated README but that was it). Hope this helps!

@camerondurham camerondurham linked a pull request Jan 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants