Add JRC-IDEES data processing pipeline #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtroendle
requested changes
Jul 16, 2021
There was a problem hiding this comment.
Only very few comments about functionality, but a lot about structuring the code and readability.
I still think readability is important here. These kinds of data processing scripts are in most cases super difficult to read but structure and descriptions can ease the pain to some degree. You may not agree with all my comments and that's fine of course.
timtroendle
approved these changes
Jul 20, 2021
|
Need to fix some bugs found on running the script before it's ready. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step to fixing #17 & #102 and blocking #119.
Now that the JRC IDEES database is available via FTP, we can roll the processing of the data into Euro-Calliope. This allows the transport, industry, and tertiary (commercial) sector data to be processed for the components that we need down the line. The processing takes the largely machine-unreadable data from JRC-IDEES and turns into tidy dataframes for use elsewhere.
Checklist
Any checks which are not relevant to the PR can be pre-checked by the PR creator. All others should be checked by the reviewer. You can add extra checklist items here if required by the PR.