Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2605 [Translation]"Force Settlement price" in the Publish feed should be "Feed price"? #2619

Closed
wants to merge 1 commit into from

Conversation

alexandr-masl
Copy link
Contributor

@alexandr-masl alexandr-masl commented Apr 16, 2019

General

Closes #2605

[Insert description of what you did, any description how to test or check your changes are welcome]

General

lease make sure the following is done:

Code Preparation

Please review all your changes one last time before committing

  • Check for unused code
  • No unrelated changes are included
  • None of the changed files are reformatting only
  • Code is self explanatory or documented
  • All written text is properly translated (english language)

Testing

The branch has been tested on the following browsers (desktop and mobile view)

  • Chrome
  • Opera
  • Firefox
  • Safari

User interface changes

Delete this section if there weren't any UI changes. Please make sure you tested your changes in all themes

  • Dark
  • Light
  • Midnight

Please provide screenshots/licecap of your changes below

@sschiessl-bcp
Copy link
Contributor

Please fill out the PR template

@sschiessl-bcp
Copy link
Contributor

Is the value that is shown actually the feed price?

Changing the translation like that is not acceptable since it causes confusion. settlement_price must translate to settlement price.

@alexandr-masl
Copy link
Contributor Author

will check now one more time

@alexandr-masl
Copy link
Contributor Author

photo_2019-04-16_16-29-04

@alexandr-masl
Copy link
Contributor Author

Is the value that is shown actually the feed price?

Changing the translation like that is not acceptable since it causes confusion. settlement_price must translate to settlement price.

yes it is, did you mean - i have to fix key settlement_price to feed_price too ?

@sschiessl-bcp
Copy link
Contributor

Closed manually, this PR is considered accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[alexandr-masl][0.25][Translation]"Force Settlement price" in the Publish feed should be "Feed price"?
2 participants