Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[alexandr-masl][0.25][Translation]"Force Settlement price" in the Publish feed should be "Feed price"? #2605

Closed
shulthz opened this issue Apr 7, 2019 · 11 comments
Closed

[alexandr-masl][0.25][Translation]"Force Settlement price" in the Publish feed should be "Feed price"? #2605

shulthz opened this issue Apr 7, 2019 · 11 comments
Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design [4b] Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform [5a] Tiny Indicates size of task. Est. less than one hour [6] RC Blockage Impact flag identifying UI Release Candidate blockage

Comments

@shulthz
Copy link
Contributor

shulthz commented Apr 7, 2019

图片

"Force Settlement price" in the Publish feed should be ""Feed price"?

bitshares-ui/app/assets/locales/locale-en.json

Line 763 in c5edb49

"settlement_price": "Force Settlement price",

@sschiessl-bcp sschiessl-bcp added [3] Bug Classification indicating the existing implementation does not match the intention of the design [4b] Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform [5a] Tiny Indicates size of task. Est. less than one hour [6] RC Blockage Impact flag identifying UI Release Candidate blockage labels Apr 8, 2019
@sschiessl-bcp
Copy link
Contributor

Task is to:

  • Double check in the code that the value is properly pushed as the feed price (no meddling with offset whatsoever
  • Fix the translation by switching to the correct key

@sschiessl-bcp sschiessl-bcp changed the title [Translation]"Force Settlement price" in the Publish feed should be "Feed price"? [0.25][Translation]"Force Settlement price" in the Publish feed should be "Feed price"? Apr 8, 2019
@alexandr-masl
Copy link
Contributor

Hi, can i take this issue ?
thanks in advance .

@sschiessl-bcp
Copy link
Contributor

It's yours. Since this is a release candidate blocker, please work on this asap

@sschiessl-bcp sschiessl-bcp changed the title [0.25][Translation]"Force Settlement price" in the Publish feed should be "Feed price"? [alexandr-masl][0.25][Translation]"Force Settlement price" in the Publish feed should be "Feed price"? Apr 10, 2019
@sschiessl-bcp
Copy link
Contributor

sschiessl-bcp commented Apr 10, 2019 •
edited
Loading

Also interested in #2603?

@alexandr-masl
Copy link
Contributor

yes, thank you.

@sschiessl-bcp
Copy link
Contributor

Status?

@alexandr-masl
Copy link
Contributor

It's done. also as 2603. I replaced in all languages, if you don't mind can push it.

@sschiessl-bcp
Copy link
Contributor

PR against develop please

@sschiessl-bcp
Copy link
Contributor

Please send PR asap, preferably yesterday :)

@alexandr-masl
Copy link
Contributor

Got it
will push today

@alexandr-masl alexandr-masl mentioned this issue Apr 17, 2019
Closed
12 tasks
sschiessl-bcp pushed a commit that referenced this issue Apr 17, 2019
sync locales
b68fa41 
For #2605 #2603

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>
@sschiessl-bcp
Copy link
Contributor

Issue escalated a4d4960

@sschiessl-bcp sschiessl-bcp mentioned this issue Apr 17, 2019
Closed
@shulthz shulthz mentioned this issue Apr 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design [4b] Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform [5a] Tiny Indicates size of task. Est. less than one hour [6] RC Blockage Impact flag identifying UI Release Candidate blockage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2605 [Translation]"Force Settlement price" in the Publish feed should be "Feed price"?
3 participants
@sschiessl-bcp @shulthz @alexandr-masl