Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 2522 - Withdraw Modal Enhancements #2523

Merged
merged 8 commits into from
Mar 21, 2019
Merged

Issue 2522 - Withdraw Modal Enhancements #2523

merged 8 commits into from
Mar 21, 2019

Conversation

startailcoon
Copy link
Contributor

General

Closes #2522

Please NOTE: Based on PR #2495
Only commit b1154d8 referes to this change.

Deposit Modal Enhancements

  • Gateways drop-down sorted alphabetically
  • Gateways drop-down lists asset pair balance

General

lease make sure the following is done:

Code Preparation

Please review all your changes one last time before committing

  • Check for unused code
  • No unrelated changes are included
  • None of the changed files are reformatting only
  • Code is self explanatory or documented
  • All written text is properly translated (english language)

Testing

The branch has been tested on the following browsers (desktop and mobile view)

  • Chrome
  • Opera
  • Firefox
  • Safari

Please provide screenshots/licecap of your changes below

WithdrawDepositWithBalance

@startailcoon
Antify Deposit/Withdraw Modals
5dfd83e 
- Full refactor of DepositWithrawAssetSelector

Updates
- AssetSelect updated to use correct asset name replacer
- AmountSelect now works without label
@startailcoon
Merge branch 'develop' of https://github.com/bitshares/bitshares-ui i…
61366bc 
…nto 1872_DepositWithdrawModalAntification
@startailcoon
Deposit Modal Enhancements
b1154d8 
- Gateways drop-down sorted alphabetically
- Gateways drop-down lists asset pair balance
@sschiessl-bcp
Copy link
Contributor

Will check once #2495 is merged

@startailcoon startailcoon mentioned this pull request Mar 12, 2019
Merged
12 tasks
@startailcoon
Copy link
Contributor Author

Rebased on parent PR, No conflicts

@sschiessl-bcp sschiessl-bcp merged commit 73fffac into develop Mar 21, 2019
@sschiessl-bcp sschiessl-bcp deleted the 2522_WithdrawModalEnhancements branch March 21, 2019 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@startailcoon @sschiessl-bcp