Issue 1872 - Antify Deposit/Withdraw Modals

[startailcoon]

• Full refactor of DepositWithrawAssetSelector

Updates

• AssetSelect updated to use correct asset name replacer
• AmountSelect now works without label

General

Closes #1872

General

lease make sure the following is done:

• Pull request is onto develop
• If you haven't already, have a look at
  • https://github.com/bitshares/bitshares-ui/blob/develop/CODE_OF_CONDUCT.md
  • https://github.com/bitshares/bitshares-ui/blob/develop/CONTRIBUTING.md

Code Preparation

Please review all your changes one last time before committing

• Check for unused code
• No unrelated changes are included
• None of the changed files are reformatting only
• Code is self explanatory or documented
• All written text is properly translated (english language)

Testing

The branch has been tested on the following browsers (desktop and mobile view)

• Chrome
• Opera
• Firefox
• Safari

User interface changes

Delete this section if there weren't any UI changes. Please make sure you tested your changes in all themes

• Dark
• Light
• Midnight

Please provide screenshots/licecap of your changes below

[sschiessl-bcp]

Deposit and Withdraw Modals do not open from Menu anymore

[startailcoon]

Strange, will investigate. Didn't see this issue, did you test it towards the recent change that fixed the issue with it?

[startailcoon]

#2483

[startailcoon]

Can't reproduce any issue with opening modals from menu.

[sschiessl-bcp]

• Load http://localhost:8080/account/blockchainprojectsbv-test-2, go to dashboard, click deposit BTS
  
  No barcode appears. Expectancy: A barcode with account name. Maybe out of scope

• After having used deposit BTS, it also wants to deposit BTS for any other asset

• please add padding when loading for deposit
  

[startailcoon]

No barcode appears. Expectancy: A barcode with account name. Maybe out of scope

This is due to some change made previously. We now use a component called <CryptoLinkFormatter> that formats the QR code link for various assets. Someone forgot to account for BTS not using the same format as Gateway assets. Fixed

please add padding when loading for deposit

Fixed

After having used deposit BTS, it also wants to deposit BTS for any other asset

Issue: Opening deposit modal from dashboard doesn't update deposit asset to the new one a user selects, but will retain the previously used one. A new issue will be created for this.

[startailcoon]

Sorry, must have missed posting my comments when resolving these. Both these notes are fixed as part of the following PR #2523.

[sschiessl-bcp]

Please resolve the conflict, I'm unsure which is the newest

[startailcoon]

Resolved @sschiessl-bcp