Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2132 - Fetch Balance object on sorting accounts (Explorer Page) #2518

Merged
merged 5 commits into from
Mar 19, 2019

Conversation

startailcoon
Copy link
Contributor

General

Closes #2132
  • Fixed loading of Balance Object on sorting accounts on explorer page
  • Caching object result to reduce calls

General

lease make sure the following is done:

Code Preparation

Please review all your changes one last time before committing

  • Check for unused code
  • No unrelated changes are included
  • None of the changed files are reformatting only
  • Code is self explanatory or documented
  • All written text is properly translated (english language)

Testing

The branch has been tested on the following browsers (desktop and mobile view)

  • Chrome
  • Opera
  • Firefox
  • Safari

User interface changes

Delete this section if there weren't any UI changes. Please make sure you tested your changes in all themes

  • Dark
  • Light
  • Midnight

Please provide screenshots/licecap of your changes below

- Caching object result to reduce calls
app/components/Explorer/Accounts.jsx Show resolved Hide resolved
app/components/Explorer/Accounts.jsx Outdated Show resolved Hide resolved
Stefan Schiessl added 2 commits March 19, 2019 09:52
deprecate winex

Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>
@sschiessl-bcp sschiessl-bcp merged commit 609971e into develop Mar 19, 2019
@sschiessl-bcp sschiessl-bcp deleted the 2132_SortingExplorerAccounts branch March 19, 2019 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants