Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.5] Sorting Explorer Accounts by Balance breaks page #2132

Closed
alexandr-masl opened this issue Nov 8, 2018 · 2 comments
Closed

[1.5] Sorting Explorer Accounts by Balance breaks page #2132

alexandr-masl opened this issue Nov 8, 2018 · 2 comments
Assignees
@startailcoon
Labels
[1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [3] Bug Classification indicating the existing implementation does not match the intention of the design [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive [5b] Small Indicates size of task. Est. between one and two hours [7] Finalized Administartion flag, notifies hours are finalized
Milestone
190329

Comments

@alexandr-masl
Copy link
Contributor

Describe the bug
The sorting for BalanceComponent in Explore -> Accounts doesn't work as expected, after few clicks appears white screen.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to Explore
  2. Click on Accounts
  3. Click on Current Balance column several times

Expected behaviour
Sort BalanceComponent without white screen.
@alexandr-masl alexandr-masl mentioned this issue Nov 8, 2018
Closed
@startailcoon
Copy link
Contributor

Issue still persists. Investigating

@startailcoon startailcoon self-assigned this Mar 10, 2019
@startailcoon startailcoon added this to the 190315 milestone Mar 10, 2019
@startailcoon startailcoon added [3] Bug Classification indicating the existing implementation does not match the intention of the design [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive [1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [5b] Small Indicates size of task. Est. between one and two hours [7] Estimated Administration flag, notifies hours are estimated and requires revisiting labels Mar 10, 2019
@startailcoon startailcoon changed the title sorting BalanceComponent [1.5] Sorting Explorer Accounts by Balance breaks page Mar 10, 2019
@startailcoon
Copy link
Contributor

Page breaks as it doesn't load the balance object before trying to sort.
Adding ChainStore load of balance object on sort, and caching to eliminate redudant calls on re-sorting.

@startailcoon startailcoon added [7] Finalized Administartion flag, notifies hours are finalized and removed [7] Estimated Administration flag, notifies hours are estimated and requires revisiting labels Mar 10, 2019
@startailcoon startailcoon mentioned this issue Mar 10, 2019
Merged
12 tasks
@startailcoon startailcoon modified the milestones: 190315, 190329 Mar 16, 2019
@sschiessl-bcp sschiessl-bcp mentioned this issue Mar 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@startailcoon startailcoon

Labels
[1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [3] Bug Classification indicating the existing implementation does not match the intention of the design [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive [5b] Small Indicates size of task. Est. between one and two hours [7] Finalized Administartion flag, notifies hours are finalized
Projects
None yet
Milestone
190329
Development

No branches or pull requests
2 participants
@startailcoon @alexandr-masl