Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix advanced examples notebook #154

Merged
merged 10 commits into from
Jan 26, 2023
Merged

Fix advanced examples notebook #154

merged 10 commits into from
Jan 26, 2023

Conversation

ayush9pandey
Copy link
Collaborator

ayush9pandey and others added 6 commits November 29, 2022 18:58
@ayush9pandey
Dev to Master for v1.2 (#148)
e1c5559 
Changes summary:
* update badges
* add corner dependency
* update version

* Repo cleanup
* Upgrade testing CI env to Python v3.10 (#146)

* Inference pickling (#145)

Co-authored-by: Ayush Pandey <ayush.9.pandey@gmail.com>
Co-authored-by: William Poole <wpoole@caltech.edu>
@ayush9pandey
update readme (#149)
5c123bc
@ayush9pandey
add setup.cfg for pypi (#150)
0e9edf2
@ayush9pandey
add contributing.md and modify instructions in readme
8d57e1e
@ayush9pandey
fix advanced examples model
0c38491
@ayush9pandey
remove other changes
74bcfde
@ayush9pandey ayush9pandey mentioned this pull request Jan 20, 2023
Closed
@ayush9pandey
Copy link
Collaborator Author

@WilliamIX please review. We need to fix the lineage examples in this notebook before merging the PR.

@Robaina Robaina mentioned this pull request Jan 23, 2023
Closed
@ayush9pandey
Copy link
Collaborator Author

@WilliamIX any idea why the tests are failing on python 3.10 on MacOS?

@WilliamIX
Copy link
Collaborator

@WilliamIX any idea why the tests are failing on python 3.10 on MacOS?

This looks like a Cython problem - maybe something about the version of python + the MacOS C++ compiler + Cython isn't working. Not the most helpful answer, I know...

@ayush9pandey ayush9pandey changed the base branch from master to dev January 26, 2023 22:15
@ayush9pandey
Copy link
Collaborator Author

Merging to dev. Will look at the errors with macos 3.10 when I merge to master.

@ayush9pandey ayush9pandey merged commit f8f4057 into dev Jan 26, 2023
@ayush9pandey ayush9pandey deleted the joss-review branch January 26, 2023 22:45
@ayush9pandey ayush9pandey mentioned this pull request Jan 27, 2023
Merged
WilliamIX pushed a commit that referenced this pull request Jan 31, 2023
@ayush9pandey
Changes to package after JOSS review 1 (#160)
acb4734 
Updates in version 1.2.1:
* Fixes advanced examples notebook (Fix advanced examples notebook #154)
* Adds contributing.md (Add contributing.md  #158)
* Adds bioscrape simulation comparison (Benchmarking bioscrape performance #159)
* Installation via python setup.py install replaced with pip install.
* New contributor guidelines.
ayush9pandey added a commit that referenced this pull request Feb 25, 2023
@ayush9pandey
Changes to package after JOSS review 1 (#160)
3aedfff 
Updates in version 1.2.1:
* Fixes advanced examples notebook (Fix advanced examples notebook #154)
* Adds contributing.md (Add contributing.md  #158)
* Adds bioscrape simulation comparison (Benchmarking bioscrape performance #159)
* Installation via python setup.py install replaced with pip install.
* New contributor guidelines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliamIX WilliamIX WilliamIX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JOSS Review - Advance example Notebook broken
2 participants
@ayush9pandey @WilliamIX