Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] invoke success callback in close() #53

Merged
merged 1 commit into from
Nov 23, 2017
Merged

[iOS] invoke success callback in close() #53

merged 1 commit into from
Nov 23, 2017

Conversation

antweb
Copy link
Contributor

@antweb antweb commented Nov 21, 2017

Fixes #52

@becvert becvert mentioned this pull request Nov 23, 2017
Closed
@emcniece
Copy link
Collaborator

emcniece commented Nov 23, 2017 •
edited
Loading

This is actually referencing the close() method - updating title.

Tested and confirmed working!

@emcniece emcniece changed the title [iOS] invoke success callback in stop() [iOS] invoke success callback in close() Nov 23, 2017
@emcniece emcniece merged commit 759642d into becvert:master Nov 23, 2017
This was referenced Nov 24, 2017
Merged
Merged
@antweb antweb deleted the issue-52 branch November 24, 2017 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antweb @emcniece