Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] zeroconf.close never invokes success/error callback #52

Closed
antweb opened this issue Nov 21, 2017 · 3 comments
Closed

[iOS] zeroconf.close never invokes success/error callback #52

antweb opened this issue Nov 21, 2017 · 3 comments

Comments

@antweb
Copy link
Contributor

antweb commented Nov 21, 2017

The behaviour of zeroconf.close() is inconsistent between Android and iOS. While Android sends a plugin result, iOS does not. As the Android version uses a background thread, it is necessary to rely on the callback to make sure the action has finished.

A simple solution would be to send a success plugin result in iOS as well.

@becvert
Copy link
Owner

becvert commented Nov 22, 2017

ok I'll have a look sometime. thank you

@emcniece
Copy link
Collaborator

@becvert I can PR today!

@becvert
Copy link
Owner

becvert commented Nov 23, 2017

#53 is fixing the close method actually.
I think the same could be apply to stop indeed
@emcniece go ahead with merging this into 1.3.0. thanks 👍

This was referenced Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants