Rename CopyMethod None to CopyMethod Direct #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnStrunk
approved these changes
Oct 27, 2021
| Expect(inst.Status.NextSyncTime).NotTo(BeNil()) | ||
| }) | ||
| // Test both None and Direct (results should be the same) | ||
| for i := range directCopyMethodTypes { |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnStrunk, tesshuflower The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@tesshuflower Now that #98 is merged, I think this will pass if you rebase it. |
Signed-off-by: Tesshu Flower <tflower@redhat.com>
tesshuflower
force-pushed
the
rename-copymethod-none
branch
from
ebb9304
to
f4d62c5
Compare
Codecov Report
@@ Coverage Diff @@
## main #99 +/- ##
=======================================
- Coverage 75.4% 75.2% -0.3%
=======================================
Files 16 16
Lines 2044 2051 +7
=======================================
+ Hits 1542 1543 +1
- Misses 398 401 +3
- Partials 104 107 +3
|
|
/lgtm |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tesshu Flower tflower@redhat.com
Describe what this PR does
Renames CopyMethod: None to CopyMethod: Direct. None will still work, but Direct has been added and will be the recommended name.
Is there anything that requires special attention?
Related issues:
#8