Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix retrieval of minio keys in e2e #98

Merged
merged 2 commits into from
Oct 27, 2021
Merged

Fix retrieval of minio keys in e2e #98

merged 2 commits into from
Oct 27, 2021

Conversation

JohnStrunk
Copy link
Member

Describe what this PR does
The bitnami/minio chart changed the name of the fields in the Secret
that hold the keys. This updates the field names so we can extract them
correctly.

Is there anything that requires special attention?

Related issues:

@JohnStrunk
Fix retrieval of minio keys in e2e
860bf38 
The bitnami/minio chart changed the name of the fields in the Secret
that hold the keys. This updates the field names so we can extract them
correctly.

Signed-off-by: John Strunk <jstrunk@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnStrunk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JohnStrunk
Copy link
Member Author

/hold

This breaks the openshift e2e, but fixes the GH action 😿

@JohnStrunk
Lock minio chart version
d505c3c 
Signed-off-by: John Strunk <jstrunk@redhat.com>
@JohnStrunk
Copy link
Member Author

/unhold

I've run manually against openshift w/ this chart version and e2e passes.
openshift/release#23074 will update the version used in openshift e2e to match, but I don't expect the pre-submit for that PR to pass until this PR is merged, so I think we'll need to lgtm this one w/ failing e2e-openshift

@JohnStrunk
Copy link
Member Author

/hold

to my surprise, openshift/release#23074 just merged... Let's see what happens.

@JohnStrunk
Copy link
Member Author

/retest

1 similar comment
@JohnStrunk
Copy link
Member Author

/retest

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #98 (d505c3c) into main (b801ed7) will decrease coverage by 0.4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main     #98     +/-   ##
=======================================
- Coverage   75.4%   75.0%   -0.5%     
=======================================
  Files         16      16             
  Lines       2044    2044             
=======================================
- Hits        1543    1534      -9     
- Misses       397     402      +5     
- Partials     104     108      +4
Impacted Files Coverage Δ
controllers/rsync_common.go 63.1% <0.0%> (-4.2%) ⬇️
controllers/volumehandler.go 67.4% <0.0%> (-1.2%) ⬇️
controllers/replicationsource_controller.go 78.6% <0.0%> (ø)

@JohnStrunk
Copy link
Member Author

/unhold
/assign @tesshuflower
🎉

@tesshuflower
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 27, 2021
@openshift-merge-robot openshift-merge-robot merged commit dda3ba0 into backube:main Oct 27, 2021
@JohnStrunk JohnStrunk deleted the fix-minio branch October 28, 2021 11:28
@JohnStrunk JohnStrunk mentioned this pull request Oct 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tesshuflower tesshuflower

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnStrunk @tesshuflower @openshift-merge-robot